From: Eddie Dawydiuk <eddie@embeddedarm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: PPC PCI bus registers
Date: Wed, 16 Sep 2009 11:58:24 -0700 [thread overview]
Message-ID: <4AB13550.1070506@embeddedarm.com> (raw)
In-Reply-To: <1251972032.15089.30.camel@pasglop>
Benjamin,
> Also, if you're going to access a PCI device directly, beware of other
> issues such as ordering. PPC is an out of order architecture, you need
> to ensure you add the appropriate memory barriers if you want to ensure
> you accesses are done in the order you write them in your program.
>
> For "standard" stuff that doesn't involve DMA or locks, an eieio after
> both MMIO loads and stores should do the trick.
I'm not sure I understand. To clarify I have an FPGA connected via the PCI bus
which implements several peripherals, I've implemented device drivers for.
Currently I am calling ioremap() to get a virtual address corresponding to the
PCI devices. Then I use ___raw_writeN / ___raw_readN for reading/writing data
via the PCI bus to the FPGA registers. From looking at io.h I believe this
method is safe with regard to out of order execution.
"* ioremap is the standard one and provides non-cacheable guarded mappings
* and can be hooked by the platform via ppc_md "
Can you verify if my understanding is correct, or let me know if I need to add
memory barriers?
--
Best Regards,
________________________________________________________________
Eddie Dawydiuk, Technologic Systems | voice: (480) 837-5200
16525 East Laser Drive | fax: (480) 837-5300
Fountain Hills, AZ 85268 | web: www.embeddedARM.com
next prev parent reply other threads:[~2009-09-16 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 23:44 PPC PCI bus registers Eddie Dawydiuk
2009-09-02 23:56 ` Grant Likely
2009-09-03 10:00 ` Benjamin Herrenschmidt
2009-09-16 18:58 ` Eddie Dawydiuk [this message]
2009-09-16 21:54 ` Benjamin Herrenschmidt
2009-09-16 22:11 ` Eddie Dawydiuk
2009-09-17 1:24 ` Benjamin Herrenschmidt
2009-09-17 16:11 ` Eddie Dawydiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB13550.1070506@embeddedarm.com \
--to=eddie@embeddedarm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.