All of lore.kernel.org
 help / color / mirror / Atom feed
From: jlenz2@math.uiuc.edu (John Lenz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] locomo.c: CodingStyle cleanups
Date: Wed, 16 Sep 2009 21:06:09 -0500	[thread overview]
Message-ID: <4AB19991.5050107@math.uiuc.edu> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901CBF46C@mi8nycmail19.Mi8.com>

H Hartley Sweeten wrote:
> EXPORT* macros should follow immediately after the closing function
> brace line.
> 
> The prototype for locomo_chip_driver() is not needed since the static
> (inline) function is located earlier in the file.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: John Lenz <lenz@cs.wisc.edu>
> 

Patch looks ok, although I am no longer active in linux development.
Patch should be sent to Pavel.

> ---
> 
> I originally sent this to the wrong list...
> 
> 
> diff --git a/arch/arm/common/locomo.c b/arch/arm/common/locomo.c
> index 2293f0c..bd36c77 100644
> --- a/arch/arm/common/locomo.c
> +++ b/arch/arm/common/locomo.c
> @@ -865,6 +865,7 @@ void locomo_gpio_set_dir(struct device *dev, unsigned int bits, unsigned int dir
>  
>  	spin_unlock_irqrestore(&lchip->lock, flags);
>  }
> +EXPORT_SYMBOL(locomo_gpio_set_dir);
>  
>  int locomo_gpio_read_level(struct device *dev, unsigned int bits)
>  {
> @@ -882,6 +883,7 @@ int locomo_gpio_read_level(struct device *dev, unsigned int bits)
>  	ret &= bits;
>  	return ret;
>  }
> +EXPORT_SYMBOL(locomo_gpio_read_level);
>  
>  int locomo_gpio_read_output(struct device *dev, unsigned int bits)
>  {
> @@ -899,6 +901,7 @@ int locomo_gpio_read_output(struct device *dev, unsigned int bits)
>  	ret &= bits;
>  	return ret;
>  }
> +EXPORT_SYMBOL(locomo_gpio_read_output);
>  
>  void locomo_gpio_write(struct device *dev, unsigned int bits, unsigned int set)
>  {
> @@ -920,6 +923,7 @@ void locomo_gpio_write(struct device *dev, unsigned int bits, unsigned int set)
>  
>  	spin_unlock_irqrestore(&lchip->lock, flags);
>  }
> +EXPORT_SYMBOL(locomo_gpio_write);
>  
>  static void locomo_m62332_sendbit(void *mapbase, int bit)
>  {
> @@ -1084,13 +1088,12 @@ void locomo_m62332_senddata(struct locomo_dev *ldev, unsigned int dac_data, int
>  
>  	spin_unlock_irqrestore(&lchip->lock, flags);
>  }
> +EXPORT_SYMBOL(locomo_m62332_senddata);
>  
>  /*
>   *	Frontlight control
>   */
>  
> -static struct locomo *locomo_chip_driver(struct locomo_dev *ldev);
> -
>  void locomo_frontlight_set(struct locomo_dev *dev, int duty, int vr, int bpwf)
>  {
>  	unsigned long flags;
> @@ -1182,11 +1185,13 @@ int locomo_driver_register(struct locomo_driver *driver)
>  	driver->drv.bus = &locomo_bus_type;
>  	return driver_register(&driver->drv);
>  }
> +EXPORT_SYMBOL(locomo_driver_register);
>  
>  void locomo_driver_unregister(struct locomo_driver *driver)
>  {
>  	driver_unregister(&driver->drv);
>  }
> +EXPORT_SYMBOL(locomo_driver_unregister);
>  
>  static int __init locomo_init(void)
>  {
> @@ -1208,11 +1213,3 @@ module_exit(locomo_exit);
>  MODULE_DESCRIPTION("Sharp LoCoMo core driver");
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("John Lenz <lenz@cs.wisc.edu>");
> -
> -EXPORT_SYMBOL(locomo_driver_register);
> -EXPORT_SYMBOL(locomo_driver_unregister);
> -EXPORT_SYMBOL(locomo_gpio_set_dir);
> -EXPORT_SYMBOL(locomo_gpio_read_level);
> -EXPORT_SYMBOL(locomo_gpio_read_output);
> -EXPORT_SYMBOL(locomo_gpio_write);
> -EXPORT_SYMBOL(locomo_m62332_senddata); 

  reply	other threads:[~2009-09-17  2:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17  0:31 [PATCH] locomo.c: CodingStyle cleanups H Hartley Sweeten
2009-09-17  2:06 ` John Lenz [this message]
2009-09-18 19:35 ` Russell King - ARM Linux
  -- strict thread matches above, loose matches on Subject: below --
2009-09-16  0:12 H Hartley Sweeten
2009-09-26  9:55 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB19991.5050107@math.uiuc.edu \
    --to=jlenz2@math.uiuc.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.