From: Jason Wessel <jason.wessel@windriver.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb console: fix mutex lock regression
Date: Wed, 16 Sep 2009 22:32:39 -0500 [thread overview]
Message-ID: <4AB1ADD7.10600@windriver.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0909162324460.24041-100000@netrider.rowland.org>
Alan Stern wrote:
> On Wed, 16 Sep 2009, Jason Wessel wrote:
>
>
>> During the 2.6.32 development the use of serial->disc_mutex was
>> introduced. In usb_console_setup() the call to
>> usb_serial_get_by_index() will obtain this mutex. The
>> usb_console_setup() must release the mutex before it completes else
>> later calls to the usb serial core will hang.
>>
>
> Apparently you didn't see my patch:
>
> http://marc.info/?l=linux-usb&m=125209260714221&w=2
>
> Did this not get into linus-next? Greg?
>
>
Maybe it was not merged at the time. We'll wait to hear from Greg.
Certainly I would opt to use your more complete implementation.
Jason.
next prev parent reply other threads:[~2009-09-17 3:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 3:08 [PATCH 0/3] usb console: 2.6.32 regression fixes Jason Wessel
2009-09-17 3:08 ` [PATCH 1/3] usb console: fix mutex lock regression Jason Wessel
2009-09-17 3:08 ` [PATCH 2/3] usb console,usb-serial: fix regression use of serial->console Jason Wessel
2009-09-17 3:08 ` [PATCH 3/3] usb console,usb-serial: pass initial console baud on to first tty open Jason Wessel
2009-09-17 3:32 ` Alan Stern
2009-09-17 3:40 ` Jason Wessel
2009-09-17 3:46 ` Alan Stern
2009-09-17 4:17 ` Jason Wessel
2009-09-17 9:14 ` Alan Cox
2009-09-17 12:16 ` Jason Wessel
2009-09-17 13:08 ` Alan Cox
2009-09-17 13:19 ` Alan Cox
2009-09-17 14:17 ` Jason Wessel
2009-09-17 16:02 ` Alan Cox
2009-09-22 20:54 ` Jason Wessel
2009-09-29 17:24 ` How to handle console devices Alan Stern
2009-09-29 22:47 ` Alan Cox
2009-09-17 3:30 ` [PATCH 2/3] usb console,usb-serial: fix regression use of serial->console Alan Stern
2009-09-17 3:32 ` Jason Wessel
2009-09-17 3:25 ` [PATCH 1/3] usb console: fix mutex lock regression Alan Stern
2009-09-17 3:32 ` Jason Wessel [this message]
2009-09-18 17:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB1ADD7.10600@windriver.com \
--to=jason.wessel@windriver.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.