All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] fsl_i2c: Add CONFIG_FSL_I2C_CUSTOM_DFSR
Date: Thu, 17 Sep 2009 08:36:32 +0200	[thread overview]
Message-ID: <4AB1D8F0.2040804@denx.de> (raw)
In-Reply-To: <OF37706726.BC369064-ONC1257633.00434B57-C1257633.00437D52@transmode.se>

Joakim Tjernlund wrote:
> Wolfgang Grandegger <wg@grandegger.com> wrote on 16/09/2009 13:45:03:
>> Joakim Tjernlund wrote:
>>> Wolfgang Grandegger <wg@denx.de> wrote on 16/09/2009 12:22:05:
>>>> Joakim Tjernlund wrote:
>>>>>> Timur Tabi <timur@freescale.com> wrote on 15/09/2009 21:04:47:
>>>>>>> Joakim Tjernlund wrote:
>>>>>>>
>>>>>>>> No, the impact on speed from DFSR is pretty small so it will
>>>>>>>> be close enough.
>>>>>>> How small?
>>>>>> From the app note:
>>>>>>   divisor = B * (A + ((3*C)/B)*2);
>>>>>>
>>>>>> C is dfsr and 10 <= A <= 30, 16 <= B <= 2048
>>>>>> Considering the actual speed may be way lower the requested speed
>>>>>> I think this is small enough.
>>>>> Once we have the new procedure in place, we can calculate the exact
>>>>> divisor so the need for extra CONFIG_ options goes away.
>>>> As Timur pointed out, a new table/algorithm would require some real
>>>> testing and also some feedback from the users. Who knows if "your"
>>>> values do not make trouble. Therefore I vote for using custom
>>>> settings for maximum flexibility:
>>>>
>>>>   CONFIG_FSL_I2C_CUSTOM_FDR
>>>>   CONFIG_FSL_I2C_CUSTOM_DFSR
>>> Oh well, since you both wanted it I added it.
>>> Sent 3 patches, the last patch impl. the latest AN2819 spec.
>>>
>>> Would you mind test it a little?
>> OK, I will do some tests later this week. What CPU do you use and at
>> what I2C bus frequency do you test?
> 
> mpc8321, I2C bus is between 34KHz and 100KHz, CSB is 133.332 MHz

OK, where can I find the new AN2819? I found Document Number: AN2919,
Rev. 5, 12/2008.

Wolfgang.

  reply	other threads:[~2009-09-17  6:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 18:45 [U-Boot] [PATCH 1/2] fsl_i2c: Wait for STOP condition to propagate Joakim Tjernlund
2009-09-15 18:45 ` [U-Boot] [PATCH 2/2] fsl_i2c: Add CONFIG_FSL_I2C_CUSTOM_DFSR Joakim Tjernlund
2009-09-15 18:51   ` Timur Tabi
2009-09-15 18:57     ` Joakim Tjernlund
2009-09-15 19:04       ` Timur Tabi
2009-09-15 19:21         ` Joakim Tjernlund
2009-09-15 19:26           ` Joakim Tjernlund
2009-09-16 10:22             ` Wolfgang Grandegger
2009-09-16 11:33               ` Joakim Tjernlund
2009-09-16 11:45                 ` Wolfgang Grandegger
2009-09-16 12:17                   ` Joakim Tjernlund
2009-09-17  6:36                     ` Wolfgang Grandegger [this message]
2009-09-17  6:39                       ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB1D8F0.2040804@denx.de \
    --to=wg@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.