From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <tj@kernel.org>
Cc: ide <linux-ide@vger.kernel.org>, stable@kernel.org
Subject: Re: [PATCH] libata: fix spurious WARN_ON_ONCE() on port freeze
Date: Thu, 17 Sep 2009 16:49:45 -0400 [thread overview]
Message-ID: <4AB2A0E9.3080009@pobox.com> (raw)
In-Reply-To: <4AB20537.4080903@kernel.org>
On 09/17/2009 05:45 AM, Tejun Heo wrote:
> Commit 54c38444fad6a99b4b19512f8f0055d69115e69e makes libata abort qcs
> after the port is frozen. This is necessary to guarantee that TF
> registers are accessed after the DMA engine is shutdown after an
> error. However, this triggers WARN_ON_ONCE() check in
> ata_qc_complete() spuriously. Move WARN_ON_ONCE() downwards such that
> failing commands while frozen doesn't trigger it.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Cc: stable<stable@kernel.org>
> ---
> drivers/ata/libata-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied
prev parent reply other threads:[~2009-09-17 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 9:45 [PATCH] libata: fix spurious WARN_ON_ONCE() on port freeze Tejun Heo
2009-09-17 20:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB2A0E9.3080009@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.