From: Jeff Garzik <jgarzik@pobox.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Kurt Roeckx <kurt@roeckx.be>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.31] sata_promise: disable hotplug on 1st gen chips
Date: Thu, 17 Sep 2009 16:51:25 -0400 [thread overview]
Message-ID: <4AB2A14D.4090004@pobox.com> (raw)
In-Reply-To: <19119.37268.448603.191642@pilspetsen.it.uu.se>
On 09/15/2009 09:07 AM, Mikael Pettersson wrote:
> 1st generation Promise SATA chips are prone to generating spurious
> hotplug events which can disrupt normal operation. This has been
> observed on 20376 and 20378 chips. This patch thus disables hotplug
> support on 1st gen chips while leaving it enabled for 2nd gen chips.
>
> The pdc_sata_hotplug_offset() function becomes redundant so it is
> removed.
>
> Tested on 1st gen 20376 and 20378 mainboard chips and on a 2nd gen
> SATA300 PCI card.
>
> Signed-off-by: Mikael Pettersson<mikpe@it.uu.se>
> Tested-by: Kurt Roeckx<kurt@roeckx.be>
> ---
> Kurt: you tested this so I added your Tested-by, I hope that's Ok?
> Jeff: this is a safe patch that I think should go to -stable soonish
>
> drivers/ata/sata_promise.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
Applied, though I would rather see hotplug be made a runtime decision:
default off, but with an option to enable
Jeff
prev parent reply other threads:[~2009-09-17 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 13:07 [PATCH 2.6.31] sata_promise: disable hotplug on 1st gen chips Mikael Pettersson
2009-09-17 20:51 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB2A14D.4090004@pobox.com \
--to=jgarzik@pobox.com \
--cc=kurt@roeckx.be \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.