From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: ide <linux-ide@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
stable@kernel.org
Subject: Re: [PATCH] pata_amd: do not filter out valid modes in nv_mode_filter
Date: Thu, 17 Sep 2009 16:51:49 -0400 [thread overview]
Message-ID: <4AB2A165.7080507@garzik.org> (raw)
In-Reply-To: <4AAC8927.4030401@gmail.com>
On 09/13/2009 01:54 AM, Robert Hancock wrote:
> On a Compaq Presario V3000 laptop (NVIDIA MCP51 chipset), pata_amd selects
> PIO0 mode for the PATA DVD-RAM drive instead of MWDMA2 which it supports:
>
> ata4.00: ATAPI: HL-DT-ST DVDRAM GSA-4084N, KQ09, max MWDMA2
> ata4: nv_mode_filter: 0x39f&0x7001->0x1, BIOS=0x0 (0x0) ACPI=0x7001 (60:600:0x11)
> ata4.00: configured for PIO0
>
> For some reason, the BIOS-set UDMA configuration returns 0 and the ACPI _GTM
> reports that UDMA2 and PIO0 are enabled. This causes nv_mode_filter to end up
> allowing only PIO0 and UDMA0-2. Since the drive doesn't support UDMA we end up
> using PIO0.
>
> Since the controllers should always support PIO4, MWDMA2 and UDMA2 regardless
> of what cable type is used, let's make sure we don't filter out these modes
> regardless of what wacky settings the BIOS is using.
>
> Signed-off-by: Robert Hancock<hancockrwd@gmail.com>
> Cc: stable@kernel.org
applied
prev parent reply other threads:[~2009-09-17 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 5:54 [PATCH] pata_amd: do not filter out valid modes in nv_mode_filter Robert Hancock
2009-09-14 9:21 ` Tejun Heo
2009-09-17 20:51 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB2A165.7080507@garzik.org \
--to=jeff@garzik.org \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.