From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755407AbZIRCZV (ORCPT ); Thu, 17 Sep 2009 22:25:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755378AbZIRCZT (ORCPT ); Thu, 17 Sep 2009 22:25:19 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:55862 "EHLO acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753494AbZIRCZP (ORCPT ); Thu, 17 Sep 2009 22:25:15 -0400 Message-ID: <4AB2EFBC.90500@oracle.com> Date: Thu, 17 Sep 2009 19:26:04 -0700 From: Randy Dunlap User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: lkml , Linus Torvalds CC: Roel Kluin Subject: [PATCH 1/3] docs: kref: double kref_put() in my_data_handler() Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: abhmt010.oracle.com [141.146.116.19] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4AB2EF81.0087:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roel Kluin Subject: kref: double kref_put() in my_data_handler() The kref_put() already occurs after the out label Signed-off-by: Roel Kluin Signed-off-by: Randy Dunlap --- Documentation/kref.txt | 1 - 1 file changed, 1 deletion(-) --- lnx-2631-rc7.orig/Documentation/kref.txt +++ lnx-2631-rc7/Documentation/kref.txt @@ -84,7 +84,6 @@ int my_data_handler(void) task = kthread_run(more_data_handling, data, "more_data_handling"); if (task == ERR_PTR(-ENOMEM)) { rv = -ENOMEM; - kref_put(&data->refcount, data_release); goto out; }