All of lore.kernel.org
 help / color / mirror / Atom feed
From: Moni Shoua <monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: How to handle illegal multicast addresses in IPoIB?
Date: Mon, 21 Sep 2009 16:31:44 +0300	[thread overview]
Message-ID: <4AB78040.9000606@Voltaire.COM> (raw)

Hi,
The problem in short: Illegal multicast addresses can be passed to ib_ipoib which will add them to the queue of multicast addresses it needs to join. From this point on ib_ipoib will get stuck in the attempt to join an illegal multicast group and without a giving a chance for other groups to try.

Recently 2 patches were sent to to deal with this problem. Both of them were rejectedm mainly from technical reasons.
Since I think that it is important to have the problem fixed I want to revive the discussion and resubmit one of them or both, according to the opinions here.

One patch (http://lists.openfabrics.org/pipermail/general/2009-August/061663.html) checks each multicast address for validity before it lets it get into the queue. 

The other patch (http://lists.openfabrics.org/pipermail/general/2009-August/061693.html) queues all addresses it gets but adds fairness to the join attempts.

My questions is: Do we need both patches? If not, which one to choose?

I think that the first patch (check validity) is good enough.

thanks
 MoniS
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2009-09-21 13:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-21 13:31 Moni Shoua [this message]
     [not found] ` <4AB78040.9000606-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
2009-09-21 14:33   ` How to handle illegal multicast addresses in IPoIB? Or Gerlitz
     [not found]     ` <4AB78EC9.7020805-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2009-09-21 14:39       ` Moni Shoua
     [not found]         ` <4AB7900F.2020406-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
2009-09-21 17:08           ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB78040.9000606@Voltaire.COM \
    --to=monis-hkgkho2ms0f+cjeuk/jdrq@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.