From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu-kvm: fix no gsi routing warning Date: Mon, 21 Sep 2009 17:56:13 +0300 Message-ID: <4AB7940D.1030404@redhat.com> References: <20090921145136.GA29405@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, quintela@redhat.com, hch@lst.de To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14315 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbZIUO4M (ORCPT ); Mon, 21 Sep 2009 10:56:12 -0400 In-Reply-To: <20090921145136.GA29405@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/21/2009 05:51 PM, Michael S. Tsirkin wrote: > When running on host kernel which does not let the guest manupulate the > gsi routing, and user requested MSI-X to be enabled, we get the > following warnings: > kvm_msix_add: kvm_get_irq_route_gsi failed: No space left on device > kvm_msix_update: kvm_update_routing_entry failed: Invalid argument > > What really happens is that we report a failure to allocate > a vector to the guest, it will retry and finally disable MSI. > > Make this clearer by checking for gsi capability and warning about > the error in a readable form. > > Can we disable msix (or, abort qemu at startup and request that the user disable msix) if the kernel doesn't provide required features? It's better than a runtime error. -- error compiling committee.c: too many arguments to function