From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3 v2] New MIIPHYBB implementation with multi-bus support
Date: Tue, 22 Sep 2009 10:01:51 -0700 [thread overview]
Message-ID: <4AB902FF.5020802@gmail.com> (raw)
In-Reply-To: <1253633264-4901-1-git-send-email-luigi.mantellini.ml@gmail.com>
Hi Luigi,
I like what you're doing here. Thanks for working towards making the BB
driver more universal.
Luigi 'Comio' Mantellini wrote:
> From: Luigi 'Comio' Mantellini <luigi.mantellini@idf-hit.com>
>
> This patch rewrites the miiphybb ( Bit-banged MII bus driver ) in order to
> support an arbitrary number of buses. This feature is useful when your board
> uses different mii buses for different phys and all (or a part) of these buses
> are implemented via bit-banging mode.
>
> The driver requires that the following macros should be defined into the board
> configuration file:
>
> CONFIG_BITBANGMII - Enable the miiphybb driver
> CONFIG_BITBANGMII_MULTI - Enable the multi bus support
>
> If the CONFIG_BITBANGMII_MULTI is not defined, the board's config file needs to define
> the following macros:
>
>
My preference would be to only support the 'multi' mode. That way we
can keep it smaller (source-wise, not binary-wise) and not use macros.
I'll give a more thorough review shortly, but just thought I'd put this
idea out there...
regards,
Ben
prev parent reply other threads:[~2009-09-22 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 15:27 [U-Boot] [PATCH 0/3 v2] New MIIPHYBB implementation with multi-bus support Luigi 'Comio' Mantellini
2009-09-22 15:27 ` [U-Boot] [PATCH 1/3 v2] Bit-banged MII driver " Luigi 'Comio' Mantellini
2009-09-22 15:27 ` [U-Boot] [PATCH 2/3 v2] Add bb_miiphy_init call before any ethernet bring-up code Luigi 'Comio' Mantellini
2009-09-22 15:27 ` [U-Boot] [PATCH 3/3 v2] Update all board to support new bbmiiphy driver (with multibus support) Luigi 'Comio' Mantellini
2009-09-22 17:01 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB902FF.5020802@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.