From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Don't call cpu_synchronize_state() in apic_init_reset() Date: Wed, 23 Sep 2009 12:00:44 +0300 Message-ID: <4AB9E3BC.7060304@redhat.com> References: <1253631112-26124-1-git-send-email-gleb@redhat.com> <1253631112-26124-3-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41667 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbZIWJAx (ORCPT ); Wed, 23 Sep 2009 05:00:53 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8N90vPt008021 for ; Wed, 23 Sep 2009 05:00:57 -0400 In-Reply-To: <1253631112-26124-3-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/22/2009 05:51 PM, Gleb Natapov wrote: > Each caller of the function already calls it. > > Signed-off-by: Gleb Natapov > --- > hw/apic.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/hw/apic.c b/hw/apic.c > index 3a2e128..a9d1fb8 100644 > --- a/hw/apic.c > +++ b/hw/apic.c > @@ -488,7 +488,6 @@ void apic_init_reset(CPUState *env) > if (!s) > return; > > - cpu_synchronize_state(env); > s->tpr = 0; > s->spurious_vec = 0xff; > s->log_dest = 0; > Still, it's safer to live this in. -- error compiling committee.c: too many arguments to function