Re: [Qemu-devel] [PATCH 4/4] virtio-console: Add a in-qemu api for open/read/write/close ports

[Gerd Hoffmann <kraxel@redhat.com>]

> diff --git a/hw/virtio-console.c b/hw/virtio-console.c
> index d750c8e..c41f13c 100644
> --- a/hw/virtio-console.c
> +++ b/hw/virtio-console.c
> @@ -58,6 +58,11 @@ struct VirtIOConsolePort {
> +    size_t (*read_callback)(const uint8_t *buf, const size_t len);

> +    if (port->read_callback) {
> +        ret = port->read_callback(buf, len);
> +    } else if (port->hd) {
> +        ret = qemu_chr_write(port->hd, buf, len);
>       }
> -    return qemu_chr_write(port->hd, buf, len);

No.  port->info->data_for_you() again ;)

> +/* Functions for use inside qemu to open and read from/write to ports */
> +VirtIOConsolePort *virtio_console_open(uint32_t id,
> +                                       size_t(*read_callback)(const uint8_t*buf,
> +                                                              const size_t len))

Anyone who wants talk using a port should be a port driver.

cheers,
   Gerd