From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miguel Aguilar Subject: Re: [PATCH v3 1/2] Input: Add DaVinci DM365 Keypad support Date: Wed, 23 Sep 2009 08:58:19 -0600 Message-ID: <4ABA378B.2070800@ridgerun.com> References: <1253217996-11548-1-git-send-email-miguel.aguilar@ridgerun.com> <4AB39A00.8080405@ridgerun.com> <4AB8D89D.6050409@ridgerun.com> <871vlyev8g.fsf@deeprootsystems.com> <20090923034627.GA1458@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.navvo.net ([74.208.67.6]:35539 "EHLO mail.navvo.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbZIWO6W (ORCPT ); Wed, 23 Sep 2009 10:58:22 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Nori, Sekhar" Cc: Dmitry Torokhov , Kevin Hilman , "davinci-linux-open-source@linux.davincidsp.com" , "clark.becker@ridgerun.com" , "linux-input@vger.kernel.org" , "santiago.nunez@ridgerun.com" , "todd.fischer@ridgerun.com" Sekhar, Nori, Sekhar wrote: > On Wed, Sep 23, 2009 at 09:16:27, Dmitry Torokhov wrote: >> On Tue, Sep 22, 2009 at 10:37:35AM -0700, Kevin Hilman wrote: >>> Miguel Aguilar writes: >>> >>>> Sekhar, >>>> >>>> If you and Sneha agree I will write driver in terms of davinci instead of dm365. >>>> >>> I add a vote the davinci* naming instead of dm365*. >>> >> Can you guarantee that this will be the only keypad implementation for >> davinci? > > No. That cannot be guaranteed. Surely there will be attempt to reuse > this before inventing new. A new implementation will be a probably be > a new driver (named after what the new implementation is called). > > So, I guess it is better to call this driver "davinci-keyscan" after [MA] Do you think that it is better naming this driver as Key Scan instead of Keypad? > what the IP has been called (http://focus.ti.com/lit/ug/sprufi8/sprufi8.pdf). > >> If not then I'd say using base model number and updating >> Kconfig text is fine. > > But hope the other way is okay too. Miguel has already submitted a new > patch using davinci naming. > > Thanks, > Sekhar > Thanks, Miguel Aguilar