From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] Don't call cpu_synchronize_state() in apic_init_reset() Date: Wed, 23 Sep 2009 17:07:11 +0200 Message-ID: <4ABA399F.6030003@web.de> References: <1253631112-26124-1-git-send-email-gleb@redhat.com> <1253631112-26124-3-git-send-email-gleb@redhat.com> <4AB9E3BC.7060304@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9665F47A19099602721EAA95" Cc: Gleb Natapov , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:51522 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbZIWPKp (ORCPT ); Wed, 23 Sep 2009 11:10:45 -0400 In-Reply-To: <4AB9E3BC.7060304@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9665F47A19099602721EAA95 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 09/22/2009 05:51 PM, Gleb Natapov wrote: >> Each caller of the function already calls it. >> >> Signed-off-by: Gleb Natapov >> --- >> hw/apic.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/hw/apic.c b/hw/apic.c >> index 3a2e128..a9d1fb8 100644 >> --- a/hw/apic.c >> +++ b/hw/apic.c >> @@ -488,7 +488,6 @@ void apic_init_reset(CPUState *env) >> if (!s) >> return; >> >> - cpu_synchronize_state(env); >> s->tpr =3D 0; >> s->spurious_vec =3D 0xff; >> s->log_dest =3D 0; >> =20 >=20 > Still, it's safer to live this in. >=20 Yet another diff to upstream... It's really time to stabilize this still a bit fuzzy register sync model, also in qemu-kvm. If you think we need it, let us push it upstream - with a sound explanation, and maybe even with more sync points for the sake of consistency. Jan --------------enig9665F47A19099602721EAA95 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkq6OaMACgkQitSsb3rl5xQzkACeIDfJqJB3mCkUHYa+mrcT2vIQ 8AEAnjy5e14M83/9AgonhBy2yjAUBuT8 =UESo -----END PGP SIGNATURE----- --------------enig9665F47A19099602721EAA95--