From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqWBI-0002xq-5S
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 14:03:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqWBD-0002qK-H1
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 14:03:07 -0400
Received: from [199.232.76.173] (port=52412 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqWBD-0002qC-EM
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 14:03:03 -0400
Received: from mail-qy0-f173.google.com ([209.85.221.173]:63440)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MqWBC-00073T-Ta
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 14:03:03 -0400
Received: by qyk3 with SMTP id 3so811809qyk.4
	for <qemu-devel@nongnu.org>; Wed, 23 Sep 2009 11:03:02 -0700 (PDT)
Message-ID: <4ABA62D0.2060205@codemonkey.ws>
Date: Wed, 23 Sep 2009 13:02:56 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20090923125818.GA13875@redhat.com>
	<f43fc5580909231007q7fbad3a0ydb07e8b8e30f5603@mail.gmail.com>
In-Reply-To: <f43fc5580909231007q7fbad3a0ydb07e8b8e30f5603@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: comments on: get page size in device init
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Blue Swirl wrote:
> On Wed, Sep 23, 2009 at 3:58 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>   
>>>     Compile msix only once
>>>
>>>     Get page size in device init.
>>>
>>>     Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>>>       
>> What was the motivation for the page size change?
>>     
>
> "Compile msix only once"
>
>   
>> It seems the only user passes TARGET_PAGE_SIZE anyway,
>> using a constant seems clearer and probably generates
>> less code. No?
>>     
>
> Yes, but then the code would depend on TARGET_PAGE_SIZE, making it
> impossible to compile the code only once.
>   

We could probably get away with doing

#define TARGET_PAGE_SIZE target_get_page_size()

And take care of a big chunk of this without passing page size 
parameters around.

Regards,

Anthony Liguori