All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/8] sbc8548: update PCI/PCI-e support code
Date: Wed, 23 Sep 2009 16:22:23 -0400	[thread overview]
Message-ID: <4ABA837F.1070107@windriver.com> (raw)
In-Reply-To: <20090923201310.41EA1832E864@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Paul Gortmaker,
> 
> In message <7d1e5723fdd2d2e1cf51559f876edf17ae8e7a46.1253315004.git.paul.gortmaker@windriver.com> you wrote:
>> The PCI/PCI-e support for the sbc8548 was based on an earlier
>> version of what the MPC8548CDS board was using, and in its
>> current state it won't even compile.  This re-syncs it to match
>> current MPC85xxCDS/MDS PCI-e support.
>>
>> It borrows from the MPC8568MDS, in that it pulls the PCI-e I/O
>> back to 0xe280_0000 (where PCI2 would be on MPC8548CDS), and
>> similarly it coalesces the PCI and PCI-e mem into one single TLB.
>>
>> Both PCI-x and PCI-e have been tested with intel e1000 cards
>> under linux (with an accompanying dts change in place)
> ...
>> diff --git a/board/sbc8548/sbc8548.c b/board/sbc8548/sbc8548.c
>> index 1db32ec..0387140 100644
>> --- a/board/sbc8548/sbc8548.c
>> +++ b/board/sbc8548/sbc8548.c
> ...
>> @@ -400,6 +400,7 @@ pci_init_board(void)
>>  	struct pci_controller *hose = &pcie1_hose;
>>  	struct pci_region *r = hose->regions;
>>  
>> +	uint io_sel = (gur->pordevsr & MPC85xx_PORDEVSR_IO_SEL) >> 19;
> 
> Please use I/O accessors. Check globally, please.

Already done - commit 48539e37c38c4f6ff78aba6134de2ae3cc3b5dab in the
85xx tree does a global sweep of the board file, and commit
ac2cb674bd5dd1405ea0413adb71c253481d9a00 (also in 85xx) is an updated
version of this commit that uses the I/O accessors, and also the new
PCI helper functions that Kumar requested.

Thanks,
Paul.

> 
> 
> Best regards,
> 
> Wolfgang Denk
> 

  reply	other threads:[~2009-09-23 20:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 23:08 [U-Boot] [PATCH 0/8] Update/enhance sbc8548 support Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 1/8] sbc8548: delete unused MPC8548CDS info carried over from port Paul Gortmaker
2009-09-18 23:08   ` [U-Boot] [PATCH 2/8] sbc8548: get_clock_freq is not valid for this board Paul Gortmaker
2009-09-18 23:08     ` [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash Paul Gortmaker
2009-09-18 23:08       ` [U-Boot] [PATCH 4/8] sbc8548: correct local bus SDRAM size from 64M to 128M Paul Gortmaker
2009-09-18 23:08         ` [U-Boot] [PATCH 5/8] sbc8548: update PCI/PCI-e support code Paul Gortmaker
2009-09-18 23:08           ` [U-Boot] [PATCH 6/8] sbc8548: enable use of PCI network cards Paul Gortmaker
2009-09-18 23:08             ` [U-Boot] [PATCH 7/8] sbc8548: allow enabling PCI via a make config option Paul Gortmaker
2009-09-18 23:08               ` [U-Boot] [PATCH 8/8] sbc8548: replace README with completely new document Paul Gortmaker
2009-09-19 17:11                 ` Kumar Gala
2009-09-19 16:50               ` [U-Boot] [PATCH 7/8] sbc8548: allow enabling PCI via a make config option Kumar Gala
2009-09-19 17:11             ` [U-Boot] [PATCH 6/8] sbc8548: enable use of PCI network cards Kumar Gala
2009-09-23 20:13           ` [U-Boot] [PATCH 5/8] sbc8548: update PCI/PCI-e support code Wolfgang Denk
2009-09-23 20:22             ` Paul Gortmaker [this message]
2009-09-19 16:55         ` [U-Boot] [PATCH 4/8] sbc8548: correct local bus SDRAM size from 64M to 128M Kumar Gala
2009-09-23 20:10           ` Wolfgang Denk
2009-09-23 20:10         ` Wolfgang Denk
2009-09-19 17:11       ` [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash Kumar Gala
2009-09-23 20:08         ` Wolfgang Denk
2009-09-23 20:15           ` Paul Gortmaker
2009-09-23 20:48             ` Wolfgang Denk
2009-09-23 22:28               ` Paul Gortmaker
2009-09-23 20:07       ` Wolfgang Denk
2009-09-19 17:11     ` [U-Boot] [PATCH 2/8] sbc8548: get_clock_freq is not valid for this board Kumar Gala
2009-09-19  4:25   ` [U-Boot] [PATCH 1/8] sbc8548: delete unused MPC8548CDS info carried over from port Kumar Gala
2009-09-19 16:05     ` Paul Gortmaker
2009-09-19 16:34       ` Kumar Gala
2009-09-19 17:11   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABA837F.1070107@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.