From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: pvops: AHCI problems with SB600
Date: Wed, 23 Sep 2009 13:30:44 -0700
Message-ID: <4ABA8574.2060501@goop.org>
References: <4AB431AD.1030205@goop.org>	<4AB4EEB8.7050107@web.de>	<20090921150634.GD20933@phenom.dumpdata.com>	<4AB89227.8050302@web.de>	<20090922140825.GB21736@phenom.dumpdata.com>	<20090923120646.GA3199@phenom.dumpdata.com>	<4ABA7578.8030201@goop.org>	<20090923193245.GA5682@phenom.dumpdata.com>
	<4ABA8088.1080807@goop.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4ABA8088.1080807@goop.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Patrick Scharrenberg <pittipatti@web.de>, Xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 09/23/09 13:09, Jeremy Fitzhardinge wrote:
> 		if (!no_iommu &&
> 		    max_pfn > MAX_DMA32_PFN &&
> 		    !printed_gart_size_msg) {
> 			printk(KERN_ERR "you are using iommu with agp, but GART size is less than 64M\n");
> 			printk(KERN_ERR "please increase GART size in your BIOS setup\n");
> 			printk(KERN_ERR "if BIOS doesn't have that option, contact your HW vendor!\n");
> 			printed_gart_size_msg = 1;
> 		}
>   

Oh, that's the wrong error message, but the other one has similar
predicates.  Hm, but it also skips the test if (swiotlb && !valid_agp)...

> I guess the "!no_iommu" clause is triggering because we have swiotlb
> set, but I wonder if that's specifically testing for the presence of a
> GART IOMMU?
>
> How does ioremap_nocache fit into this?  Is the mapping failing in some
> way and causing this code to fail?  Or am I misunderstanding?
>
>   
>> This is exhibited only when dom0 has more than 4GB, so if you do dom_mem=max:4GB
>> the machine boots succesfully.
>>   
>>     
> The test above also tests "max_pfn > MAX_DMA32_PFN" which limiting
> memory would avoid.
>   

    J