All of lore.kernel.org
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: DaVinci: Fix divide by	zero	error during 1st execution
Date: Wed, 23 Sep 2009 18:44:15 -0700	[thread overview]
Message-ID: <4ABACEEF.8080000@boundarydevices.com> (raw)
In-Reply-To: <20090923171039.GB3457@sirena.org.uk>

Mark Brown wrote:
> On Fri, Sep 11, 2009 at 02:29:02PM -0700, Troy Kisky wrote:
>> When both playback and capture stream were open
>> davinci_i2s_hw_params was setting parameters for
>> the wrong stream. The fix for davinci_i2s_hw_params
>> is sufficient, but it looks like a race still happens
>> in davici_pcm_open. This patch also makes the race smaller
>> but the next patch provides a better fix.
> 
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> 
> Applied both, thanks.  Sorry about the delay in applying these - not
> sure what I was waiting for there.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

I think you were waiting for me to remove the need for the
comment:

+	/*
+	 * dma_params must be first because rtd->dai->cpu_dai->private_data
+	 * is cast to a pointer of an array of struct davinci_pcm_dma_params in
+	 * davinci_pcm_open.
+	 */

Which is doable.

Do you still want this fixed?

Thanks
Troy

  reply	other threads:[~2009-09-24  1:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 21:29 [PATCH 1/2] ASoC: DaVinci: Fix divide by zero error during 1st execution Troy Kisky
2009-09-11 21:29 ` [PATCH 2/2] ASoC: Davinci: Fix race with cpu_dai->dma_data Troy Kisky
2009-09-11 22:52   ` Troy Kisky
2009-09-23 17:10 ` [PATCH 1/2] ASoC: DaVinci: Fix divide by zero error during 1st execution Mark Brown
2009-09-24  1:44   ` Troy Kisky [this message]
2009-09-24 14:36     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABACEEF.8080000@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.