All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] perf_counter: cleanup for __perf_event_sched_*()
Date: Fri, 25 Sep 2009 09:22:29 +0800	[thread overview]
Message-ID: <4ABC1B55.3020108@cn.fujitsu.com> (raw)
In-Reply-To: <1253695230.7695.122.camel@twins>



Peter Zijlstra wrote:

> 
> Hrm.. I think its not just a cleanup, but an actual bugfix.
> 
> The intent was to call event_sched_{in,out}() for single counter groups
> because that's cheaper than group_sched_{in,out}(), however..
> 
>  - as you noticed, I got the condition wrong, it should have read:
> 
>      list_empty(&event->sibling_list)
> 
>  - it failed to call group_can_go_on() which deals with ->exclusive.
> 
>  - it also doesn't call hw_perf_group_sched_in() which might break
>    power.
> 

Yeah, I'll fix the title

> Also, I'm not sure I like the comments and WARN_ON bits, the changelog
> should be sufficient.
> 

Um, I'll remove the comments and WARN_ON_ONCE()

Thanks,
Xiao

  reply	other threads:[~2009-09-25  1:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22  8:47 [PATCH] perf_counter: cleanup for __perf_event_sched_in() Xiao Guangrong
2009-09-22  9:20 ` Paul Mackerras
2009-09-22  9:27   ` Xiao Guangrong
2009-09-22  9:32     ` [PATCH v2] " Xiao Guangrong
2009-09-22  9:39 ` [PATCH] " Paul Mackerras
2009-09-22 11:17   ` Peter Zijlstra
2009-09-23  2:45   ` Xiao Guangrong
2009-09-23  3:32     ` Paul Mackerras
2009-09-23  8:10       ` [PATCH 1/2] perf_counter: cleanup for __perf_event_sched_*() Xiao Guangrong
2009-09-23  8:13         ` [PATCH 2/2] perf_counter: optimize for perf_event_init_task() Xiao Guangrong
2009-09-23  8:43           ` Peter Zijlstra
2009-09-25  1:23             ` Xiao Guangrong
2009-09-23  8:40         ` [PATCH 1/2] perf_counter: cleanup for __perf_event_sched_*() Peter Zijlstra
2009-09-25  1:22           ` Xiao Guangrong [this message]
2009-09-25  5:51           ` [PATCH 1/2 v2] perf_counter: fix " Xiao Guangrong
2009-09-25  5:54             ` [PATCH 2/2 v2] optimize for perf_event_init_task() Xiao Guangrong
2009-09-25  8:55               ` Peter Zijlstra
2009-10-01  7:31                 ` Ingo Molnar
2009-10-01  7:47               ` [tip:perf/urgent] perf_event: Clean up perf_event_init_task() tip-bot for Xiao Guangrong
2009-09-25  8:55             ` [PATCH 1/2 v2] perf_counter: fix for __perf_event_sched_*() Peter Zijlstra
2009-10-01  7:46             ` [tip:perf/urgent] perf_event: Fix event group handling in __perf_event_sched_*() tip-bot for Xiao Guangrong
2009-09-22 11:12 ` [PATCH] perf_counter: cleanup for __perf_event_sched_in() Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABC1B55.3020108@cn.fujitsu.com \
    --to=xiaoguangrong@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.