All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jin Dongming <jin.dongming@np.css.fujitsu.com>
To: LKLM <linux-kernel@vger.kernel.org>
Cc: "Paul E. McKenney " <paulmck@linux.vnet.ibm.com>,
	AKPM  <akpm@linux-foundation.org>,
	"David Howells" <dhowells@redhat.com>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Kenji Kaneshige" <kaneshige.kenji@jp.fujitsu.com>,
	"Hidetoshi Seto" <seto.hidetoshi@jp.fujitsu.com>
Subject: [Patch x86-tip] Clean up the warning message about RCU not defined
Date: Fri, 25 Sep 2009 13:52:59 +0900	[thread overview]
Message-ID: <4ABC4CAB.7090302@np.css.fujitsu.com> (raw)

(This fix is for commit 4765c1db84c73f775eb1822a009117cbae524e9e
   Titled "rcu-tiny: The Bloatwatch Edition, v6")

When the kernel is built, there is some message printed as
following:
    include/linux/rcupdate.h:80:7: \
        warning: "CONFIG_TINY_RCU" is not defined

So I did "grep _RCU .config" to search the information of "CONFIG_TINY_RCU"
in .config file and the result is listed as following:
    Command:
        grep _RCU .config
    Result:
        CONFIG_TREE_RCU=y
        # CONFIG_TREE_PREEMPT_RCU is not set
        # CONFIG_TINY_RCU is not set
        CONFIG_RCU_TRACE=y
        CONFIG_RCU_FANOUT=64
        # CONFIG_RCU_FANOUT_EXACT is not set
        CONFIG_TREE_RCU_TRACE=y
        # CONFIG_RCU_TORTURE_TEST is not set
        # CONFIG_RCU_CPU_STALL_DETECTOR is not set

Though the "WARNING" does not give impact to build kernel, I think
it should be cleaned up. And I made the patch for modifying it.
With this patch there is not any other warning message of
CONFIG_TINY_RCU and the kernel could be built successfully. And I
confirmed that the built kernel works well.

Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
---
 include/linux/rcupdate.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index b2f1e10..fe5c560 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -77,7 +77,7 @@ extern int rcu_scheduler_active;
 
 #if defined(CONFIG_TREE_RCU) || defined(CONFIG_TREE_PREEMPT_RCU)
 #include <linux/rcutree.h>
-#elif CONFIG_TINY_RCU
+#elif defined(CONFIG_TINY_RCU)
 #include <linux/rcutiny.h>
 #else
 #error "Unknown RCU implementation specified to kernel configuration"
-- 
1.6.2.2


             reply	other threads:[~2009-09-25  4:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25  4:52 Jin Dongming [this message]
2009-09-25  6:15 ` [Patch x86-tip] Clean up the warning message about RCU not defined Paul E. McKenney
2009-09-25  9:39 ` David Howells
2009-09-26 14:17 ` [tip:core/rcu] rcu: " tip-bot for Jin Dongming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABC4CAB.7090302@np.css.fujitsu.com \
    --to=jin.dongming@np.css.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.