From: Gerd Hoffmann <kraxel@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of silently exiting
Date: Fri, 25 Sep 2009 10:48:54 +0200 [thread overview]
Message-ID: <4ABC83F6.3060901@redhat.com> (raw)
In-Reply-To: <20090924035908.GA4584@amit-x200.redhat.com>
On 09/24/09 05:59, Amit Shah wrote:
> Hey Markus,
>
> On (Wed) Sep 23 2009 [22:53:27], Markus Armbruster wrote:
>> Amit Shah<amit.shah@redhat.com> writes:
>>
>>> If initializing a device fails, show the name of the device
>>> and then exit
>>
>> "and then exit" is misleading, as you don't add an exit.
>
> The 'return NULL' does that -- the calling function exits.
> (doesn't the subject line clarify that?)
I have patches in the queue which will wind up this via device_add
monitor command. Caller will *not* exit then ;)
cheers,
Gerd
prev parent reply other threads:[~2009-09-25 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 11:14 [Qemu-devel] [PATCH] qdev: show failing device name instead of silently exiting Amit Shah
2009-09-23 20:53 ` Markus Armbruster
2009-09-24 3:59 ` Amit Shah
2009-09-24 13:30 ` Markus Armbruster
2009-09-24 13:31 ` Amit Shah
2009-09-24 14:22 ` Markus Armbruster
2009-09-24 15:36 ` Amit Shah
2009-09-24 17:50 ` Markus Armbruster
2009-09-25 8:48 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABC83F6.3060901@redhat.com \
--to=kraxel@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.