All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Broken board: mpc5121ads
Date: Fri, 25 Sep 2009 06:30:36 -0400	[thread overview]
Message-ID: <4ABC9BCC.9060801@gmail.com> (raw)

Hi Martha, list,

A couple of lines got scrambled (exchanged!?) on the mpc5121.  I did not 
have the time to do a "git bisect" or "blame" to figure out where it 
happened.

The error is:

$ cat LOG/mpc5121ads.ERR
mpc5121ads.c: In function 'initdram':
mpc5121ads.c:176: error: expected '}' before numeric constant
make[1]: *** [mpc5121ads.o] Error 1
make: *** [board/freescale/mpc5121ads/libmpc5121ads.a] Error 2

The problem is the list is re-ordered in
   ./board/freescale/mpc5121ads/mpc5121ads.c
         u32 elpida_mddrc_config[4] = {
                 CONFIG_SYS_MDDRC_TIME_CFG0,
                 CONFIG_SYS_MDDRC_TIME_CFG1_ELPIDA,
                 CONFIG_SYS_MDDRC_TIME_CFG2_ELPIDA  <-- should be last?
                 CONFIG_SYS_MDDRC_SYS_CFG_ELPIDA,
         };



Doing a quick search in gmain, the code in question was added by Martha 
M Stan (CC:ed):
   <http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/68478>

If someone fixes it, that would be great, otherwise I'll look at it tonight.

Thanks,
gvb

             reply	other threads:[~2009-09-25 10:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25 10:30 Jerry Van Baren [this message]
2009-09-25 12:22 ` [U-Boot] Broken board: mpc5121ads Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2009-09-25 13:25 m marx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABC9BCC.9060801@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.