From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mr921-0002yH-Hw for mharc-grub-devel@gnu.org; Fri, 25 Sep 2009 07:32:09 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mr91y-0002tz-6c for grub-devel@gnu.org; Fri, 25 Sep 2009 07:32:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mr91t-0002pT-2e for grub-devel@gnu.org; Fri, 25 Sep 2009 07:32:05 -0400 Received: from [199.232.76.173] (port=49029 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mr91s-0002pH-Sn for grub-devel@gnu.org; Fri, 25 Sep 2009 07:32:00 -0400 Received: from mx20.gnu.org ([199.232.41.8]:44574) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mr91s-0004Ja-AF for grub-devel@gnu.org; Fri, 25 Sep 2009 07:32:00 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mr91r-0007wP-Ag for grub-devel@gnu.org; Fri, 25 Sep 2009 07:31:59 -0400 Received: by fg-out-1718.google.com with SMTP id e21so115924fga.12 for ; Fri, 25 Sep 2009 04:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=XdnnwFPSOLUoH0bUipmcZGpWI295e/V1KA33eQfPCQs=; b=jlEJlbr5YZI44/d1XjeLgAsg3jqNzoG8vDQlS98+PabVgaBnBOpkONxIqKlpp9JK+T 0oT05GgDbnziSf9A6Xn8Cb7yoPdxMY/ZUh48qWa7P7f8PUdwRWzr/SeW8p1ueOse21Yg 8o6Q5rND2a5nanlbW5/LSvI17trd9dfWAkFMs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=AcbqewwQ25sE7/kuu8Tn5TMEGOoKbXiGn3QyyjKhEEHjZ9vsIS3isvW2yxGge/4kZG 8yKH9ltSOBsDNSxKBUdEmonfklg/tJdmhnxF14yK62egc0VWz2Byb6VSGXYz6sExu7E9 7fxCuLPGLaGV8F/AdTIdIG2Mb4UrpZ5UdUMyQ= Received: by 10.86.227.27 with SMTP id z27mr859241fgg.66.1253878316960; Fri, 25 Sep 2009 04:31:56 -0700 (PDT) Received: from ?82.130.80.52? (hg-public-dock-52-dhcp.ethz.ch [82.130.80.52]) by mx.google.com with ESMTPS id 12sm187217fgg.23.2009.09.25.04.31.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 25 Sep 2009 04:31:56 -0700 (PDT) Message-ID: <4ABCAA2A.7010807@gmail.com> Date: Fri, 25 Sep 2009 13:31:54 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <4ab7a42f.8353f10a.25a9.4896SMTPIN_ADDED@mx.google.com> <4AB841B9.30708@gmail.com> <4AB88317.1070603@gmail.com> <20090924120219.GA4558@thorin> In-Reply-To: <20090924120219.GA4558@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: patch to replace (UUID=) hack X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2009 11:32:06 -0000 Robert Millan wrote: > On Tue, Sep 22, 2009 at 09:56:07AM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Try attached WIP patch >> > > Excellent. This was quite necessary. I have to admit my (UUID=) kludge was > a really poor solution (although in that time, the alternatives weren't > so straightforwarded). > > I'm inclined to allow this for inclusion in 1.97, since it fixes a problem > that could be seen as a bug (the overhead can be huge, specially in slow > setups). > > This patch isn't ready yet. grub-install has to be fixed for grub-install for sparc64 too but I have no possibility to test it on sparc64. I haven't tested it on multi-drive config on x86 yet. >> - prefix_drive="(UUID=${uuid})" >> - modules="$modules fs_uuid" >> + config="search_fs_uuid ${uuid} root" >> + modules="$modules search_fs_uuid" >> > > Note we don't need to explicitly include "root" there. This would save 5 > bytes, and make the behaviour a bit more consistent (since root is > implicit afterwards). > If "root" is omitted the found filename is printed on console