From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MrBr0-00076l-03 for mharc-grub-devel@gnu.org; Fri, 25 Sep 2009 10:32:58 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MrBqx-00074H-Te for grub-devel@gnu.org; Fri, 25 Sep 2009 10:32:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MrBqs-0006wl-Vp for grub-devel@gnu.org; Fri, 25 Sep 2009 10:32:55 -0400 Received: from [199.232.76.173] (port=36394 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrBqs-0006wZ-P1 for grub-devel@gnu.org; Fri, 25 Sep 2009 10:32:50 -0400 Received: from mail-fx0-f205.google.com ([209.85.220.205]:51030) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MrBqs-0002ZR-9h for grub-devel@gnu.org; Fri, 25 Sep 2009 10:32:50 -0400 Received: by fxm1 with SMTP id 1so2207369fxm.31 for ; Fri, 25 Sep 2009 07:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=PnLP6YxRXfKEPVOaSUgFd2NLc5qgR0oBwx+PeCE3ER0=; b=D9BGf3Cex39nNtt1rAQqic+cd9ef4F8g/X1wfsXnqoWISrqFXlro5bXVeh7c0sBksv cCosGoyM3u4CBdJLTexB5A2eBjOmTOZATC1GzY9k9WcwEFYwESNwa8pCFRnK+pTdCDSp v81CJA0e7L9wpLCuCtbG02tvHMZEmkf7g0Q9w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=OFFL3NoE5pLTcWo8RmEH962ewnYrkbOm8yonhkHt/Sh8tKyBwsirhyHDj8QnlL+p/s MRHQTinYY5lhkYBLVwtCIvMFEwHUnCe6NI6xTCT8qp/vXiPT7hV4btWsw0XACdlKSBkd CWBz0JGRKdhD5qQF2RloF0NkxpgJGpCLjwWXs= Received: by 10.86.217.8 with SMTP id p8mr906151fgg.73.1253889169164; Fri, 25 Sep 2009 07:32:49 -0700 (PDT) Received: from ?82.130.80.210? (hg-public-dock-210-dhcp.ethz.ch [82.130.80.210]) by mx.google.com with ESMTPS id l19sm519537fgb.15.2009.09.25.07.32.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 25 Sep 2009 07:32:48 -0700 (PDT) Message-ID: <4ABCD48F.3000409@gmail.com> Date: Fri, 25 Sep 2009 16:32:47 +0200 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <4ab7a42f.8353f10a.25a9.4896SMTPIN_ADDED@mx.google.com> <4AB841B9.30708@gmail.com> <4AB88317.1070603@gmail.com> <20090924120219.GA4558@thorin> <4ABCAA2A.7010807@gmail.com> <20090925141403.GA6401@thorin> In-Reply-To: <20090925141403.GA6401@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: davem@davemloft.net Subject: Re: patch to replace (UUID=) hack X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2009 14:32:56 -0000 Robert Millan wrote: > On Fri, Sep 25, 2009 at 01:31:54PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Tue, Sep 22, 2009 at 09:56:07AM +0200, Vladimir 'phcoder' Serbinenko wrote: >>> >>> >>>> Try attached WIP patch >>>> >>>> >>> Excellent. This was quite necessary. I have to admit my (UUID=) kludge was >>> a really poor solution (although in that time, the alternatives weren't >>> so straightforwarded). >>> >>> I'm inclined to allow this for inclusion in 1.97, since it fixes a problem >>> that could be seen as a bug (the overhead can be huge, specially in slow >>> setups). >>> >>> >>> >> This patch isn't ready yet. grub-install has to be fixed for >> grub-install for sparc64 too but I have no possibility to test it on >> sparc64. I haven't tested it on multi-drive config on x86 yet. >> > > This code duplication is problematic. Would be nice to have those two > files unified in long term :-/ > > I'm not sure about this. This code deals with sparc-specific stuff and if it's unified with i386-pc it may tend to be broken. But I can't make any definite statement since I'm not familiar with sparc64. CC'ing David Miller. >>>> - prefix_drive="(UUID=${uuid})" >>>> - modules="$modules fs_uuid" >>>> + config="search_fs_uuid ${uuid} root" >>>> + modules="$modules search_fs_uuid" >>>> >>>> >>> Note we don't need to explicitly include "root" there. This would save 5 >>> bytes, and make the behaviour a bit more consistent (since root is >>> implicit afterwards). >>> >>> >> If "root" is omitted the found filename is printed on console >> > > I guess that's because -s wasn't used? > > Yes. Using options would drag extcmd.mod without real need (for normal mode "search" with old syntax is still available)