All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] TI OMAP3 Use arm init sequence to initialize i2c
Date: Mon, 28 Sep 2009 07:53:29 +0200	[thread overview]
Message-ID: <4AC04F59.5000501@googlemail.com> (raw)
In-Reply-To: <4AC0493C.7080302@denx.de>

Hi Heiko,

Heiko Schocher wrote:
> Hello Tom,
> 
> Tom Rix wrote:
>> This changes fixes an early i2c error.
>>
>> It appears that I2C is working because once a read or write
>> error is detected, the omap24xx_i2c driver calls i2c_init
>> inside its error handling check.
>>
>> While it is ok to attempt error handling this way, the boards
>> must not depend on this side effect to initialize it's i2c.
>>
>> Instead of explicitly calling i2c_init for every board, use
>> the generic arm initialization in lib_arm/board.c. By defining
>> the config variable CONFIG_HARD_I2C, the omap3 i2c initialization
>> is included in the init_sequence table.
>>
>> Run tested on Beagle.
>> Compile tested on the omap3's
>>
>> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
>> ---
> 
> Patch does not apply:

It seems that it applies to u-boot-ti. Is it ok to move it through 
u-boot-ti into mainline?

Best regards

Dirk

  reply	other threads:[~2009-09-28  5:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24 16:35 [U-Boot] TI OMAP3 Fixing i2c initialization Tom Rix
2009-09-24 16:35 ` [U-Boot] [PATCH 1/1] TI OMAP3 Use arm init sequence to initialize i2c Tom Rix
2009-09-26  5:54   ` Dirk Behme
2009-09-28  5:27   ` Heiko Schocher
2009-09-28  5:53     ` Dirk Behme [this message]
2009-09-28  5:46       ` Heiko Schocher
2009-09-29  6:19   ` Dirk Behme
2009-09-29 12:49     ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC04F59.5000501@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.