From: Artem Bityutskiy <dedekind1@gmail.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: util-linux-ng@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] UBIFS: Add /dev/ubiX_Y naming scheme in open_ubi
Date: Mon, 28 Sep 2009 15:02:28 +0300 [thread overview]
Message-ID: <4AC0A5D4.2060609@gmail.com> (raw)
In-Reply-To: <71cd59b00909280453w31fcd22co4c41167e125b9188@mail.gmail.com>
On 09/28/2009 02:53 PM, Corentin Chary wrote:
>>> + if (!strncmp("/dev/", name, 5))
>>> + name = name + 5;
>>> +
>>> if (name[0] != 'u' || name[1] != 'b' || name[2] != 'i')
>>> return ERR_PTR(-EINVAL);
>>
>> But UBI volume may have arbitrary names. Could we invent something
>> better?
>
>
> Using name and kern_path we can find the corresponding inode (and
> major/minor informations).
> ubi_open_volume use ubi_num and vol_id.
> vol_id is minor()-1, but major is not related to ubi_num.
>
> UBI have a "ubi_major2num" internally, is it ok to export this symbol ?
>
> Then we could do something like
> ubi_open_volume(ubi_major2num(major()), minor()-1)
Sounds good.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2009-09-28 12:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 11:11 [PATCH 0/3] Add support for UBI and UBIFS Corentin Chary
2009-08-24 11:11 ` [PATCH 1/3] blkid: add UBI volume support Corentin Chary
2009-08-24 11:11 ` [PATCH 2/3] blkid: add ubifs support Corentin Chary
2009-08-24 11:11 ` [PATCH 3/3] blkid: add UBIFS test image to blkid test suite Corentin Chary
2009-09-02 9:24 ` [PATCH 1/3] blkid: add UBI volume support Karel Zak
2009-09-02 10:10 ` Artem Bityutskiy
2009-09-18 10:52 ` Corentin Chary
2009-09-19 1:23 ` Theodore Tso
2009-09-24 14:14 ` Karel Zak
2009-09-24 21:57 ` Corentin Chary
2009-09-25 7:19 ` Artem Bityutskiy
2009-09-25 7:56 ` Karel Zak
2009-08-31 19:03 ` [PATCH 0/3] Add support for UBI and UBIFS Corentin Chary
2009-08-31 21:25 ` Karel Zak
2009-09-24 14:06 ` Karel Zak
2009-09-24 22:41 ` Corentin Chary
2009-09-24 22:47 ` [PATCH] UBIFS: Add /dev/ubiX_Y naming scheme in open_ubi Corentin Chary
2009-09-25 11:37 ` Adrian Hunter
2009-09-25 12:27 ` Corentin Chary
2009-09-28 11:39 ` Artem Bityutskiy
2009-09-28 11:53 ` Corentin Chary
2009-09-28 12:02 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC0A5D4.2060609@gmail.com \
--to=dedekind1@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=util-linux-ng@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.