From: Marius Storm-Olsen <mstormo@gmail.com>
To: Michael Wookey <michaelwookey@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] generators/vcproj.pm: remove UNICODE from build
Date: Mon, 28 Sep 2009 14:39:24 +0200 [thread overview]
Message-ID: <4AC0AE7C.3080308@gmail.com> (raw)
In-Reply-To: <d2e97e800909280346s12c205f2gf95ff4c135d4625c@mail.gmail.com>
Michael Wookey said the following on 28.09.2009 12:46:
> Defining UNICODE for MSVC IDE builds results in certain Win32 WIDE API's
> receiving ANSI strings. The result of which is an invalid use of the API
> and will end in either data corruption or an application crash.
>
> Prevent the use of WIDE API's when building with the MSVC IDE for
> compatibility with msysGit.
>
> Signed-off-by: Michael Wookey <michaelwookey@gmail.com>
> ---
After manually editing the patch until it applied (some headers which
gt-am didn't like):
Acked-by: Marius Storm-Olsen <mstormo@gmail.com>
--
.marius
prev parent reply other threads:[~2009-09-28 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 10:46 [PATCH] generators/vcproj.pm: remove UNICODE from build Michael Wookey
2009-09-28 12:39 ` Marius Storm-Olsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC0AE7C.3080308@gmail.com \
--to=mstormo@gmail.com \
--cc=git@vger.kernel.org \
--cc=michaelwookey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.