From: Huang Shijie <shijie8@gmail.com>
To: Nikita Danilov <danilov@gmail.com>
Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] rmap : tidy the code
Date: Tue, 29 Sep 2009 10:06:07 +0800 [thread overview]
Message-ID: <4AC16B8F.1060308@gmail.com> (raw)
In-Reply-To: <8acda98c0909280430w2700826cu55f9629bafab066f@mail.gmail.com>
Nikita Danilov wrote:
> I agree that adding EFAULT check into page_check_address() is better.
> The only call-site that does not call vma_address() before
> page_check_address() is __xip_unmap() and it explicitly BUG_ON()s on
> the same condition.
>
>
If adding vma_address() into page_check_address() , it's bad for
__xip_unmap to change its code.
__xip_unmap must fake a page to satisfy the new "page_check_address()".
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-09-29 1:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 9:03 [PATCH] rmap : tidy the code Huang Shijie
2009-09-28 10:44 ` Hugh Dickins
2009-09-28 11:30 ` Nikita Danilov
2009-09-29 2:06 ` Huang Shijie [this message]
2009-09-29 10:28 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC16B8F.1060308@gmail.com \
--to=shijie8@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=danilov@gmail.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.