From: Benny Halevy <bhalevy@panasas.com>
To: Jjgod Jiang <jiangjiang-U4AKAne5IzAR5TUyvShJeg@public.gmane.org>
Cc: nfsv4@linux-nfs.org, pnfs@linux-nfs.org,
NFS list <linux-nfs@vger.kernel.org>
Subject: Re: [pnfs] [PATCH] Fix session initialization when following referrals
Date: Tue, 29 Sep 2009 09:43:52 +0200 [thread overview]
Message-ID: <4AC1BAB8.7050807@panasas.com> (raw)
In-Reply-To: <alpine.OSX.2.00.0909291327360.21014-uDfGT2BMUji44ywRPIzf9A@public.gmane.org>
On Sep. 29, 2009, 7:35 +0200, Jjgod Jiang <jiangjiang-U4AKAne5IzAR5TUyvShJeg@public.gmane.org> wrote:
> Hi,
>
> When following NFSv4 referrals, nfs will initialize the session of the
> client with nfs4_alloc_session() and expecting to recover the session
> on SEQUENCE operation. However, nfs41_setup_sequence() expects the
> fc_slot_table->highest_used_slotid of this session to be -1, otherwise
> it will simply return -EAGAIN without recovering the session. This
> patch complete nfs4_alloc_session() so that nfs41_setup_sequence() can
> successfully return when following referrals.
Ack.
I'll merge this patch also in my tree for the upcoming Bakeathon.
Benny
P.S. please use linux-nfs@vger.kernel.org rather than nfsv4@linux-nfs.org
>
> --- nfs/nfs4proc.c 2009-09-17 09:20:59.000000000 +0800
> +++ nfs4proc.c 2009-09-29 13:18:08.000000000 +0800
> @@ -4789,6 +4789,7 @@ struct nfs4_session *nfs4_alloc_session(
> clp->cl_cons_state = NFS_CS_SESSION_INITING;
>
> tbl = &session->fc_slot_table;
> + tbl->highest_used_slotid = -1;
> spin_lock_init(&tbl->slot_tbl_lock);
> rpc_init_wait_queue(&tbl->slot_tbl_waitq, "ForeChannel Slot table");
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> pNFS mailing list
> pNFS@linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
parent reply other threads:[~2009-09-29 7:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.OSX.2.00.0909291327360.21014-uDfGT2BMUji44ywRPIzf9A@public.gmane.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC1BAB8.7050807@panasas.com \
--to=bhalevy@panasas.com \
--cc=jiangjiang-U4AKAne5IzAR5TUyvShJeg@public.gmane.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.