Re: [Qemu-devel] [PATCH 6/6] vnc: Add a virtio-console-bus device to send / receive guest clipboard

[Gerd Hoffmann <kraxel@redhat.com>]

>   static void client_cut_text(VncState *vs, size_t len, uint8_t *text)
>   {
> +    virtio_console_write(&virtcon_vnc->port, text, len);

Needs "if (virtcon_vnc)" ?

> +    if (virtcon_vnc) {
> +        virtio_console_open(&virtcon_vnc->port);
> +    }

Like it is done here?

There is no virtio_console_close() in this patch.  Does this work 
correctly after multiple connects + disconnects (with multiple vnc 
clients connected at the same time)?

I think when moving the buffering and host_connected state tracking into 
the port driver (patch 4/6) which is the only user of the facility you 
don't need these open/close calls at all.

cheers
   Gerd