Re: [PATCH 26/27] Enable 32bit dirty log pointers on 64bit host

[Avi Kivity <avi@redhat.com>]

On 09/30/2009 03:17 PM, Avi Kivity wrote:
>>   {
>>       struct page *page[1];
>> @@ -2331,7 +2374,7 @@ static int kvm_vm_mmap(struct file *file, 
>> struct vm_area_struct *vma)
>>   static struct file_operations kvm_vm_fops = {
>>       .release        = kvm_vm_release,
>>       .unlocked_ioctl = kvm_vm_ioctl,
>> -    .compat_ioctl   = kvm_vm_ioctl,
>> +    .compat_ioctl   = kvm_vm_compat_ioctl,
>>       .mmap           = kvm_vm_mmap,
>>   };
>   static int kvm_vm_fault(struct vm_area_struct *vma, struct vm_fault 
> *vmf)
>
> This is a bit painful - I tried to avoid compat_ioctl.  Maybe it's 
> better to have dirty_bitmap_virt, given no existing users are impacted.
>

But that misses compat_ptr().  So it looks like we'll need compat_ioctl.

Patch looks fine, except s/log.log/log/.  I'd also sizeof(compat_log) 
instead of sizeof(log) to avoid frightening reviewers.

-- 
error compiling committee.c: too many arguments to function