From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH 1/3] restart: make sure all tasks are in sys_restart Date: Wed, 30 Sep 2009 21:53:03 -0400 Message-ID: <4AC40B7F.7070602@librato.com> References: <20090929165342.GA10076@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090929165342.GA10076-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: Linux Containers List-Id: containers.vger.kernel.org There is no need the add another sync point at the beginning of restart. The bug was elsewhere - in reparent_thread() the code tested the child's flags for PF_RESTARTING instead of the parent's. Oren. Serge E. Hallyn wrote: > Make sure that all prepared tasks are in sys_restart before the > coordinator proceeds. Otherwise, it was possible for the last > task actually in sys_restart to sync before the straggler was in > sys_restart, sending that task a signal and causing that task to > exit. Then since there are not enough tasks completing restart, > the restart operation ends up hanging, waiting for the killed task. > > Signed-off-by: Serge E. Hallyn > ---