From: Gilad Ben-Yossef <gilad@codefidence.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>,
"Ori Finkalman" <ori@comsleep.com>,
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Subject: Re: [PATCHv2] IPv4 TCP fails to send window scale option when window scale is zero
Date: Thu, 01 Oct 2009 18:12:28 +0200 [thread overview]
Message-ID: <4AC4D4EC.1010803@codefidence.com> (raw)
In-Reply-To: <4AC4BD1E.6060706@gmail.com>
Eric Dumazet wrote:
> Gilad Ben-Yossef a écrit :
>
>> From: Ori Finkelman <ori@comsleep.com>
>>
>> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
>> index 5200aab..fcd278a 100644
>> --- a/net/ipv4/tcp_output.c
>> +++ b/net/ipv4/tcp_output.c
>> @@ -361,6 +361,7 @@ static inline int tcp_urg_mode(const struct tcp_sock
>> *tp)
>> #define OPTION_SACK_ADVERTISE (1 << 0)
>> #define OPTION_TS (1 << 1)
>> #define OPTION_MD5 (1 << 2)
>> +#define OPTION_WSCALE (1 << 3)
>>
>
> I manually applied your patch and tested it.
>
> So far so good, it works well.
>
Glad to hear. Thank you both Eric and Ilpo for the review.
> But you'll need to find correct way to submit a patch so that your mailer doesnt
> mangle the content.
>
> File Documentation/email-clients.txt contains useful tips.
>
>
>
Arrggghh... I thought I have subdued Thunderbird but it tricked me. My
prefs.js got re-written somehow. My sincere apologies. This is not my
week with MUA.
I also noticed I put the signed-off-by in the wrong place...
Next email is version 3 - same content, hopefully correct formatting.
Thanks again.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker & CTO
Codefidence Ltd.
Web: http://codefidence.com
Cell: +972-52-8260388
Skype: gilad_codefidence
Tel: +972-8-9316883 ext. 201
Fax: +972-8-9316884
Email: gilad@codefidence.com
Check out our Open Source technology and training blog - http://tuxology.net
"Now the world has gone to bed
Darkness won't engulf my head
I can see by infra-red
How I hate the night."
prev parent reply other threads:[~2009-10-01 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 9:39 [PATCHv2] IPv4 TCP fails to send window scale option when window scale is zero Gilad Ben-Yossef
2009-10-01 14:30 ` Eric Dumazet
2009-10-01 16:12 ` Gilad Ben-Yossef [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC4D4EC.1010803@codefidence.com \
--to=gilad@codefidence.com \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
--cc=ori@comsleep.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.