All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mem_mtest: fix error reporting, allow escape with ^C
Date: Thu, 01 Oct 2009 20:04:27 -0400	[thread overview]
Message-ID: <4AC5438B.903@windriver.com> (raw)
In-Reply-To: <200910011957.51226.vapier@gentoo.org>

Mike Frysinger wrote:
> On Thursday 01 October 2009 19:52:27 Paul Gortmaker wrote:
>>  		if (iteration_limit && iterations > iteration_limit) {
>> -			printf("Tested %d iteration(s) without errors.\n",
>> -				iterations-1);
>> +			printf("Tested %d iteration(s) with %lu errors.\n",
>> +				iterations-1, errs);
>>  			return 0;
> 
> if you're showing the errs variable, then presumably it could possibly be non-
> zero, so you wouldnt want to return 0 right ?
> 	return !!errs;
> 
>>  char *argv[]) incr = -incr;
>>  	}
>>  #endif
>> -	return rcode;
>> +	return 0;
> 
> i dont think you want to return 0 all the time here right ?
> 	return !!errs;

Doh! I had it in my mind to "return errs!=0;" and then forgot.

Thanks, I'll respin and resend tomorrow.
Paul.

> 
> otherwise, the basic ^C handling is something that has annoyed me in the past, 
> so acked-by for that :)
> -mike

  reply	other threads:[~2009-10-02  0:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 19:21 [U-Boot] [PATCH] mem_mtest: bail out after finding 1st memory error Paul Gortmaker
2009-09-30 20:23 ` Wolfgang Denk
2009-09-30 20:53   ` Paul Gortmaker
2009-09-30 21:46     ` Wolfgang Denk
2009-10-01 14:00       ` Paul Gortmaker
2009-10-01 18:33         ` Wolfgang Denk
2009-10-01 23:52           ` [U-Boot] [PATCH] mem_mtest: fix error reporting, allow escape with ^C Paul Gortmaker
2009-10-01 23:57             ` Mike Frysinger
2009-10-02  0:04               ` Paul Gortmaker [this message]
2009-10-02 22:18                 ` Paul Gortmaker
2009-10-03  6:19                   ` Mike Frysinger
2009-10-18 20:57                   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC5438B.903@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.