From: TARUISI Hiroaki <taruishi.hiroak@jp.fujitsu.com>
To: linux-btrfs@vger.kernel.org
Cc: chris.mason@oracle.com
Subject: [PATCH] btrfsck: Fix Check limit in check_node/leaf.
Date: Fri, 02 Oct 2009 14:39:19 +0900 [thread overview]
Message-ID: <4AC59207.9080309@jp.fujitsu.com> (raw)
In-Reply-To: <4AC59118.6030707@jp.fujitsu.com>
In btrfsck.c( check_node/leaf ), it seems that last pair of
ptrs and items are not checked at 2 place.
Signed-off-by: TARUISI Hiroaki <taruishi.hiroak@jp.fujitsu.com>
---
btrfsck.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/btrfsck.c b/btrfsck.c
index 73f1836..ecc7b19 100644
--- a/btrfsck.c
+++ b/btrfsck.c
@@ -1720,7 +1720,7 @@ static int check_node(struct btrfs_root *root,
if (memcmp(parent_key, &key, sizeof(key)))
return 1;
}
- for (i = 0; nritems > 1 && i < nritems - 2; i++) {
+ for (i = 0; nritems > 1 && i < nritems - 1; i++) {
btrfs_node_key(buf, &key, i);
btrfs_node_key_to_cpu(buf, &cpukey, i + 1);
if (btrfs_comp_keys(&key, &cpukey) >= 0)
@@ -1759,7 +1759,7 @@ static int check_leaf(struct btrfs_root *root,
(unsigned long long)btrfs_header_bytenr(buf));
return 1;
}
- for (i = 0; nritems > 1 && i < nritems - 2; i++) {
+ for (i = 0; nritems > 1 && i < nritems - 1; i++) {
btrfs_item_key(buf, &key, i);
btrfs_item_key_to_cpu(buf, &cpukey, i + 1);
if (btrfs_comp_keys(&key, &cpukey) >= 0) {
--
1.6.2.1
next prev parent reply other threads:[~2009-10-02 5:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 5:35 [PATCH] btrfs-progs: bug fixes TARUISI Hiroaki
2009-10-02 5:39 ` TARUISI Hiroaki [this message]
2009-10-02 5:52 ` [PATCH] btrfs-progs: CRC on disk printed correctly in CRC error message TARUISI Hiroaki
2009-10-02 5:52 ` [PATCH] btrfsck: CRC error case handling TARUISI Hiroaki
2009-10-02 19:09 ` [PATCH] btrfs-progs: bug fixes Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC59207.9080309@jp.fujitsu.com \
--to=taruishi.hiroak@jp.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.