From: Ingo van Lil <inguin@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation
Date: Fri, 02 Oct 2009 14:12:43 +0200 [thread overview]
Message-ID: <4AC5EE3B.5090200@gmx.de> (raw)
In-Reply-To: <200910021306.38589.sr@denx.de>
On 10/02/2009 01:06 PM, Stefan Roese wrote:
>> The CFI driver does not reset the device's watchdog, so long-running
>> flash operations will cause the watchdog timer to expire. A comment in
>> flash_status_check() suggests that udelay() is expected to reset the
>> watchdog, but I can't find any architecture where it does.
>
> PPC does it this way. udelay() in lib_ppc/time.c calls wait_ticks(). And here
> you will find WATCHDOG_RESET.
You're right. Seems to be an exception, though: According to ctags there
are 40 separate implementations of udelay(), and the ones in lib_ppc and
lib_nios seem to be the only ones that actually do call WATCHDOG_RESET.
> Which platform are you using? I support this needs to be fixed in your
> platform.
I'm using an Atmel AT91-based custom board, and the udelay() function
can be found in cpu/arm926ejs/at91/timer.c. Unfortunately there's no
central udelay() implementation in lib_arm.
Regards,
Ingo
next prev parent reply other threads:[~2009-10-02 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 10:34 [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation Ingo van Lil
2009-10-02 11:06 ` Stefan Roese
2009-10-02 12:12 ` Ingo van Lil [this message]
2009-10-03 23:29 ` Wolfgang Denk
2009-10-04 11:15 ` Ingo van Lil
2009-10-04 11:49 ` Graeme Russ
2009-10-02 12:30 ` Wolfgang Denk
2009-10-02 18:31 ` Mike Frysinger
2009-10-02 19:35 ` Wolfgang Denk
2009-10-02 20:21 ` J. William Campbell
2009-10-02 21:59 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC5EE3B.5090200@gmx.de \
--to=inguin@gmx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.