From: William Allen Simpson <william.allen.simpson@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH] TCPCT-1: adding a sysctl
Date: Fri, 02 Oct 2009 18:00:07 -0400 [thread overview]
Message-ID: <4AC677E7.8030606@gmail.com> (raw)
In-Reply-To: <4AC63DD1.3030705@gmail.com>
William Allen Simpson wrote:
> William Allen Simpson wrote:
>> This is a straightforward re-implementation of an earlier patch, that no
>> longer applies cleanly, that was reviewed:
>>
>> http://thread.gmane.org/gmane.linux.network/102586
>>
> In that thread, David Miller wrote:
>
> "This looks mostly fine to me. I would even advocate not using a config
> option for this."
>
> It would make the code look cleaner, and with the sysctl instead, it
> would probably be fine. But SYN cookies has both.
>
> Before I go much further, I'd like guidance.
>
Based on Andi's expressed desire for more complete code before reviewing, and
the general utility of using a sysctl instead, I'll remove the config #ifdefs.
Sorry, I was overly cautious....
next prev parent reply other threads:[~2009-10-02 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 4:00 query: adding a sysctl William Allen Simpson
2009-10-02 5:57 ` Stephen Hemminger
2009-10-02 14:58 ` [PATCH] TCPCT-1: " William Allen Simpson
2009-10-02 17:52 ` William Allen Simpson
2009-10-02 22:00 ` William Allen Simpson [this message]
2009-10-02 21:06 ` Andi Kleen
2009-10-02 21:46 ` William Allen Simpson
2009-10-02 22:48 ` David Miller
2009-10-03 0:32 ` William Allen Simpson
2009-10-03 6:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC677E7.8030606@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.