Re: [PATCH] OMAP3: RX51: support sleep indicator LEDs

[Roger Quadros <ext-roger.quadros@nokia.com>]

ext Kevin Hilman wrote:
> The sleep indicator LEDs can be enabled/disabled by toggling GPIO162.
> Request this GPIO in RX51 board init, disable by default and expose
> GPIO162 to userspace so LEDs can be toggled from userspace:

It would also make more sense to use gpio_export_link() to provide a named link 
to userspace (e.g. sleep_ind, instead of GPIO162), as it is possible for gpio 
number to change among board revisions and userspace shouldn't bother about that.

-roger

> 
> To enable:
> 
>   # echo 1 > /sys/class/gpio/gpio162/value
> 
> To disable:
> 
>   # echo 0 > /sys/class/gpio/gpio162/value
> 
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
>  arch/arm/mach-omap2/board-rx51.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
> index f9196c3..6ad44d8 100644
> --- a/arch/arm/mach-omap2/board-rx51.c
> +++ b/arch/arm/mach-omap2/board-rx51.c
> @@ -31,6 +31,8 @@
>  #include <mach/gpmc.h>
>  #include <mach/usb.h>
>  
> +#define RX51_GPIO_SLEEP_IND 162
> +
>  static struct omap_lcd_config rx51_lcd_config = {
>  	.ctrl_name	= "internal",
>  };
> @@ -74,6 +76,11 @@ static void __init rx51_init(void)
>  	/* Ensure SDRC pins are mux'd for self-refresh */
>  	omap_cfg_reg(H16_34XX_SDRC_CKE0);
>  	omap_cfg_reg(H17_34XX_SDRC_CKE1);
> +
> +	if (!(gpio_request(RX51_GPIO_SLEEP_IND, "SLEEP_IND"))) {
> +		gpio_direction_output(RX51_GPIO_SLEEP_IND, 0);
> +		gpio_export(RX51_GPIO_SLEEP_IND, 1);
> +	}
>  }
>  
>  static void __init rx51_map_io(void)