From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758434AbZJELnL (ORCPT ); Mon, 5 Oct 2009 07:43:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757658AbZJELnL (ORCPT ); Mon, 5 Oct 2009 07:43:11 -0400 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:39201 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757257AbZJELnK (ORCPT ); Mon, 5 Oct 2009 07:43:10 -0400 X-Sasl-enc: MnZ4t8Zwh4AoV6GAdz/HNvVpGQOEt6sYlZNuE1EZgueb 1254742952 Message-ID: <4AC9DBA5.1090701@imap.cc> Date: Mon, 05 Oct 2009 13:42:29 +0200 From: Tilman Schmidt User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.8.1.23) Gecko/20090825 SeaMonkey/1.1.18 MIME-Version: 1.0 To: Michael Buesch CC: i4ldeveloper@listserv.isdn4linux.de, Carsten Paeth , Karsten Keil , Karsten Keil , Armin Schindler , isdn4linux@listserv.isdn4linux.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] isdn/capi: fix up CAPI subsystem workaround locking a bit References: <20091003120657.2228911186C@xenon.ts.pxnet.com> <200910032026.24451.mb@bu3sch.de> <200910032035.21884.mb@bu3sch.de> In-Reply-To: <200910032035.21884.mb@bu3sch.de> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sat, 2009-10-03 20:35:19 +0200, Michael Buesch wrote: >> I remember that handle_minor_send() and/or handle_minor_recv() showed up >> in the crash backtraces. So if you move them out of the critical >> section, you can as well remove the lock completely. > > here's my original mail: > http://lkml.indiana.edu/hypermail/linux/kernel/0605.0/0455.html > > Note the patch in that mail does _not_ fix the issue, as it turned out later. > Then I did the workaround-lock patch, which _did_ fix it. Thanks for the info. So do I understand correctly that after: commit 6aa65472d18703064898eefb5eb58f7ecd0d8912 Author: Michael Buesch Date: Mon Jun 26 00:25:30 2006 -0700 [PATCH] CAPI crash / race condition you were actually still seeing LIST_POISON2 Oopses in capiminor_del_ack(), but after: commit 053b47ff249b9e0a634dae807f81465205e7c228 Author: Michael Buesch Date: Mon Feb 12 00:53:26 2007 -0800 [PATCH] Workaround CAPI subsystem locking issue they were gone? That's interesting. I'll try to wrap my mind around this. capiminor_del_ack() isn't that big, after all. It's unfortunate that these crashes only seem to occur with one specific device (FritzCard DSL) which I don't have. Can anyone shed some light on what that device is doing differently from other ISDN cards? Thanks, Tilman - -- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKydulQ3+did9BuFsRAsYVAJ9e5azOPmNycMHZM6onfsDIY21a5wCffNh5 14WY2tYjla7wmmVgCHe+qDo= =BgmY -----END PGP SIGNATURE----- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tilman Schmidt Subject: Re: [PATCH RFC] isdn/capi: fix up CAPI subsystem workaround locking a bit Date: Mon, 05 Oct 2009 13:42:29 +0200 Message-ID: <4AC9DBA5.1090701@imap.cc> References: <20091003120657.2228911186C@xenon.ts.pxnet.com> <200910032026.24451.mb@bu3sch.de> <200910032035.21884.mb@bu3sch.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Karsten Keil , Carsten Paeth , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, i4ldeveloper-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public.gmane.org, isdn4linux-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public.gmane.org, Karsten Keil , Armin Schindler To: Michael Buesch Return-path: In-Reply-To: <200910032035.21884.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i4ldeveloper-bounces-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public.gmane.org Errors-To: i4ldeveloper-bounces-JX7+OpRa80SjiSfgN6Y1Ib39b6g2fGNp@public.gmane.org List-Id: netdev.vger.kernel.org LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQpIYXNoOiBTSEExCgpPbiBTYXQsIDIw MDktMTAtMDMgMjA6MzU6MTkgKzAyMDAsIE1pY2hhZWwgQnVlc2NoIHdyb3RlOgoKPj4gSSByZW1l bWJlciB0aGF0IGhhbmRsZV9taW5vcl9zZW5kKCkgYW5kL29yIGhhbmRsZV9taW5vcl9yZWN2KCkg c2hvd2VkIHVwCj4+IGluIHRoZSBjcmFzaCBiYWNrdHJhY2VzLiBTbyBpZiB5b3UgbW92ZSB0aGVt IG91dCBvZiB0aGUgY3JpdGljYWwKPj4gc2VjdGlvbiwgeW91IGNhbiBhcyB3ZWxsIHJlbW92ZSB0 aGUgbG9jayBjb21wbGV0ZWx5Lgo+IAo+IGhlcmUncyBteSBvcmlnaW5hbCBtYWlsOgo+IGh0dHA6 Ly9sa21sLmluZGlhbmEuZWR1L2h5cGVybWFpbC9saW51eC9rZXJuZWwvMDYwNS4wLzA0NTUuaHRt bAo+IAo+IE5vdGUgdGhlIHBhdGNoIGluIHRoYXQgbWFpbCBkb2VzIF9ub3RfIGZpeCB0aGUgaXNz dWUsIGFzIGl0IHR1cm5lZCBvdXQgbGF0ZXIuCj4gVGhlbiBJIGRpZCB0aGUgd29ya2Fyb3VuZC1s b2NrIHBhdGNoLCB3aGljaCBfZGlkXyBmaXggaXQuCgpUaGFua3MgZm9yIHRoZSBpbmZvLiBTbyBk byBJIHVuZGVyc3RhbmQgY29ycmVjdGx5IHRoYXQgYWZ0ZXI6Cgpjb21taXQgNmFhNjU0NzJkMTg3 MDMwNjQ4OThlZWZiNWViNThmN2VjZDBkODkxMgpBdXRob3I6IE1pY2hhZWwgQnVlc2NoIDxtYkBi dTNzY2guZGU+CkRhdGU6ICAgTW9uIEp1biAyNiAwMDoyNTozMCAyMDA2IC0wNzAwCgogICAgW1BB VENIXSBDQVBJIGNyYXNoIC8gcmFjZSBjb25kaXRpb24KCnlvdSB3ZXJlIGFjdHVhbGx5IHN0aWxs IHNlZWluZyBMSVNUX1BPSVNPTjIgT29wc2VzIGluCmNhcGltaW5vcl9kZWxfYWNrKCksIGJ1dCBh ZnRlcjoKCmNvbW1pdCAwNTNiNDdmZjI0OWI5ZTBhNjM0ZGFlODA3ZjgxNDY1MjA1ZTdjMjI4CkF1 dGhvcjogTWljaGFlbCBCdWVzY2ggPG1iQGJ1M3NjaC5kZT4KRGF0ZTogICBNb24gRmViIDEyIDAw OjUzOjI2IDIwMDcgLTA4MDAKCiAgICBbUEFUQ0hdIFdvcmthcm91bmQgQ0FQSSBzdWJzeXN0ZW0g bG9ja2luZyBpc3N1ZQoKdGhleSB3ZXJlIGdvbmU/IFRoYXQncyBpbnRlcmVzdGluZy4gSSdsbCB0 cnkgdG8gd3JhcCBteSBtaW5kIGFyb3VuZAp0aGlzLiBjYXBpbWlub3JfZGVsX2FjaygpIGlzbid0 IHRoYXQgYmlnLCBhZnRlciBhbGwuCgpJdCdzIHVuZm9ydHVuYXRlIHRoYXQgdGhlc2UgY3Jhc2hl cyBvbmx5IHNlZW0gdG8gb2NjdXIgd2l0aCBvbmUgc3BlY2lmaWMKZGV2aWNlIChGcml0ekNhcmQg RFNMKSB3aGljaCBJIGRvbid0IGhhdmUuIENhbiBhbnlvbmUgc2hlZCBzb21lIGxpZ2h0IG9uCndo YXQgdGhhdCBkZXZpY2UgaXMgZG9pbmcgZGlmZmVyZW50bHkgZnJvbSBvdGhlciBJU0ROIGNhcmRz PwoKVGhhbmtzLApUaWxtYW4KCi0gLS0KVGlsbWFuIFNjaG1pZHQgICAgICAgICAgICAgICAgICAg IEUtTWFpbDogdGlsbWFuQGltYXAuY2MKQm9ubiwgR2VybWFueQpEaWVzZSBOYWNocmljaHQgYmVz dGVodCB6dSAxMDAlIGF1cyB3aWVkZXJ2ZXJ3ZXJ0ZXRlbiBCaXRzLgpVbmdlw7ZmZm5ldCBtaW5k ZXN0ZW5zIGhhbHRiYXIgYmlzOiAoc2llaGUgUsO8Y2tzZWl0ZSkKLS0tLS1CRUdJTiBQR1AgU0lH TkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEuNC40IChNaW5nVzMyKQpDb21tZW50OiBVc2lu ZyBHbnVQRyB3aXRoIE1vemlsbGEgLSBodHRwOi8vZW5pZ21haWwubW96ZGV2Lm9yZwoKaUQ4REJR Rkt5ZHVsUTMrZGlkOUJ1RnNSQXNZVkFKOWU1YXpPUG1OeWNNSFpNNm9uZnNESVkyMWE1d0NmZk5o NQoxNFdZMnRZamxhN3dtbVZnQ0hlK3FEbz0KPUJnbVkKLS0tLS1FTkQgUEdQIFNJR05BVFVSRS0t LS0tCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmk0bGRl dmVsb3BlciBtYWlsaW5nIGxpc3QKaTRsZGV2ZWxvcGVyQGxpc3RzZXJ2LmlzZG40bGludXguZGUK aHR0cHM6Ly93d3cuaXNkbjRsaW51eC5kZS9tYWlsbWFuL2xpc3RpbmZvL2k0bGRldmVsb3Blcg==