All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abdoulaye Walsimou Gaye <walsimou@walsimou.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH-ARM 1/4, v2] Clean-up of cpu_arm920t and 	cpu_arm920t_s3c24x0 code
Date: Mon, 05 Oct 2009 18:35:29 +0200	[thread overview]
Message-ID: <4ACA2051.8070807@walsimou.com> (raw)
In-Reply-To: <4AC66FDE.4060502@fearnside-systems.co.uk>

kevin.morfitt at fearnside-systems.co.uk a ?crit :
> Here are links to the patches and notes on their states:
> - [U-boot] [PATCH-ARM] CONFIG_SYS_HZ change for cpu/arm920t/s3c24x0 boards:
>   http://lists.denx.de/pipermail/u-boot/2009-September/thread.html, 
>   JP said it looked OK but needed testing, then it was tested by Wolfgang
> - [U-Boot] [PATCH-ARM 1/4, v2] Clean-up of cpu/arm920t and 
>   cpu/arm920t/s3c24x0 code (this patch): one comment so far (your own)
> - [U-Boot] [PATCH-ARM 2/4] Clean-up of s3c24x0 header files:
>   http://lists.denx.de/pipermail/u-boot/2009-September/060111.html, 
>   no comments as yet
> - [U-Boot] [PATCH-ARM 3/4, v2] Clean-up of s3c24x0 drivers excluding nand 
>   driver, http://lists.denx.de/pipermail/u-boot/2009-September/061583.html,
>   one comment by Gaye Abdoulaye Walsimou, fixed in v2
> - [U-Boot] [PATCH-ARM 4/4, v2] Clean-up of s3c24x0 nand driver,
>   http://lists.denx.de/pipermail/u-boot/2009-September/061584.html,
>   v1 was Acked by Scott here - 
>   http://lists.denx.de/pipermail/u-boot/2009-September/060580.html
>
>   
>> But there are remained more works for cleaning
>>     
>
> My aim is to clean up just the s3c24x0 common code so I can later add support 
> for the Embest SBC2440-II Board. I can see that the rest of the arm920t code 
> also needs cleaning but this would be a much bigger job and could be done 
> later - I'd rather limit these patches to s3c24x0 code. 
>
>   
>> please use lower case name at C structure's members and functions
>>     
>
> I think I have changed all structure names to lower case in the s3c24x0 code.
> I also think I've changed all function names to lower case except where
> the change would affect too many other areas - for example, if I change 
> get_HCLK() to get_hclk() in cpu/arm920t/s3c24x0/speed.c I'd also need to 
> change the same in include/common.h, cpu/lh7a40x, arm920t/imx and 
> arm1176/s3c64xx and all functions that call get_HCLK() throughout u-boot. 
> Again, this does need doing but could be done later.
>   
Kevin,
As nobody seems to have an objection about your changes, I think you can 
just go ahead and make available
changes to support s3c2440 and your board.

Cheers,

  reply	other threads:[~2009-10-05 16:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-26 11:36 [U-Boot] [PATCH-ARM 1/4, v2] Clean-up of cpu_arm920t and cpu_arm920t_s3c24x0 code kevin.morfitt at fearnside-systems.co.uk
     [not found] ` <1f3430fb0909290850tcf0dce0v265974b683459c28@mail.gmail.com>
2009-09-29 15:56   ` Minkyu Kang
2009-10-02 21:25     ` kevin.morfitt at fearnside-systems.co.uk
2009-10-05 16:35       ` Abdoulaye Walsimou Gaye [this message]
2009-10-06  8:20         ` kevin.morfitt at fearnside-systems.co.uk
2009-10-09  6:07           ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACA2051.8070807@walsimou.com \
    --to=walsimou@walsimou.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.