From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Anders Melchiorsen" <mail@spoon.kalibalik.dk>,
"Björn Gustavsson" <bgustavsson@gmail.com>,
"Sverre Rabbelier" <srabbelier@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Teach 'rebase -i' the command "amend"
Date: Tue, 06 Oct 2009 07:53:55 +0200 [thread overview]
Message-ID: <4ACADB73.1080504@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0910052318230.4985@pacific.mpi-cbg.de>
Johannes Schindelin schrieb:
> Are you serious? "rebase -i" was _always_ about showing an edit script,
> i.e. to tell Git _what_ you want to do with _which_ commits, identified by
> short commit names.
>
> The oneline was _always_ meant as a pure convenience for the user.
Good that you mention it: The one-liner is really convenient. I tend to
replace it by reminders like "====== fix unused var", "===== edit msg",
etc. (after marking the commit "edit") and I'm glad that rebase-i later
prints the one-liner from the insn file rather than the original subject
line before it stops.
(I do it this way because on Windows I can't afford to call rebase-i on a
long patch series for every single task. Rather, I plan the tasks while
the insn editor is open, and this way I keep reminders about what the plan
was.)
No, I definitely don't want the one-liners to end up in the commit
message. ;-)
-- Hannes
prev parent reply other threads:[~2009-10-06 6:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-04 19:06 [PATCH] Teach 'rebase -i' the command "amend" Björn Gustavsson
2009-10-04 21:09 ` Johannes Schindelin
2009-10-05 6:08 ` Björn Gustavsson
2009-10-05 6:33 ` Junio C Hamano
2009-10-05 9:17 ` Johannes Schindelin
2009-10-05 9:39 ` Sverre Rabbelier
2009-10-05 16:10 ` Björn Gustavsson
2009-10-05 19:43 ` Anders Melchiorsen
2009-10-05 20:50 ` Johannes Schindelin
2009-10-05 21:07 ` Junio C Hamano
2009-10-05 21:13 ` Sverre Rabbelier
2009-10-05 21:26 ` Johannes Schindelin
2009-10-06 5:53 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACADB73.1080504@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=bgustavsson@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@spoon.kalibalik.dk \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.