From: Tejun Heo <tj@kernel.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: stack bloat after stackprotector changes
Date: Tue, 06 Oct 2009 14:53:56 +0900 [thread overview]
Message-ID: <4ACADB74.5090508@kernel.org> (raw)
In-Reply-To: <4ACA5EB0.4010707@sandeen.net>
Eric Sandeen wrote:
> It seems that after:
>
> commit 5d707e9c8ef2a3596ed5c975c6ff05cec890c2b4
> Author: Tejun Heo <tj@kernel.org>
> Date: Mon Feb 9 22:17:39 2009 +0900
>
> stackprotector: update make rules
>
> xfs stack usage jumped up a fair bit;
>
> Not a lot in each case but could be significant as it accumulates.
>
> I'm not familiar w/ the gcc stack protector feature; would this be an
> expected result?
Yeah, it adds a bit of stack usage per each function call and around
arrays which seem like they could overflow, so the behavior is
expected and I can see it can be a problem with function call depth
that deep. Has it caused actual stack overflow?
Thanks.
--
tejun
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-10-06 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 21:01 stack bloat after stackprotector changes Eric Sandeen
2009-10-06 5:53 ` Tejun Heo [this message]
2009-10-06 14:14 ` Eric Sandeen
2009-10-07 1:32 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACADB74.5090508@kernel.org \
--to=tj@kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.