From: Gilad Ben-Yossef <gilad@codefidence.com>
To: Andreas Henriksson <andreas@fatal.se>
Cc: netdev@vger.kernel.org, ori@comsleep.com
Subject: Re: [PATCH] iproute2 add hoplimit and reordering route options usage and parsing
Date: Tue, 06 Oct 2009 14:37:06 +0200 [thread overview]
Message-ID: <4ACB39F2.6080002@codefidence.com> (raw)
In-Reply-To: <20091006114142.GA11012@amd64.fatal.se>
Andreas Henriksson wrote:
> Hello!
>
> On Mon, Oct 05, 2009 at 10:54:21AM +0200, Gilad Ben-Yossef wrote:
>
>> iproute2 git HEAD (spotted originally on 2.6.26, so it's probably not new)
>> does not parse the hoplimit route option when proccessing parameters, nor
>> does it print hoplimit and reordering options in the usage lines.
>>
>
> I'm happy you brought this up and know the author. The Debian package
> has been carrying this code, which is now in the form of a patch available
> here:
> http://git.debian.org/?p=collab-maint/pkg-iproute.git;a=blob;f=debian/patches/hoplimit.dpatch
>
> I didn't know who the original author was which is why I haven't submitted it,
> but it seems you know the history....
>
Not exactly. I know the history of the patch *I sent* (and btw, it seems
I got the author name wrong). I don't think it is related to the one
Debian is carrying.
> The above patch also includes some minor documentation updates which you seem
> to be missing and might want to integrate in your version of the patch.
>
All right. I will add those documentation changes as well and resend as
version 2.
> Looking forward to be able to drop the patch in the debian package!
>
>
>
>
I take it you ACK the patch as the Debian package maintainer?
Thanks!
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker & CTO
Codefidence Ltd.
Web: http://codefidence.com
Cell: +972-52-8260388
Skype: gilad_codefidence
Tel: +972-8-9316883 ext. 201
Fax: +972-8-9316884
Email: gilad@codefidence.com
Check out our Open Source technology and training blog - http://tuxology.net
"Now the world has gone to bed
Darkness won't engulf my head
I can see by infra-red
How I hate the night."
next prev parent reply other threads:[~2009-10-06 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 8:54 [PATCH] iproute2 add hoplimit and reordering route options usage and parsing Gilad Ben-Yossef
2009-10-06 11:41 ` Andreas Henriksson
2009-10-06 12:37 ` Gilad Ben-Yossef [this message]
2009-10-06 13:40 ` [PATCH] iproute2 add hoplimit parsing and update usage and documentation Gilad Ben-Yossef
2009-10-06 17:14 ` Eric Dumazet
2009-10-06 17:34 ` Stephen Hemminger
2009-12-01 23:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACB39F2.6080002@codefidence.com \
--to=gilad@codefidence.com \
--cc=andreas@fatal.se \
--cc=netdev@vger.kernel.org \
--cc=ori@comsleep.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.