Re: [PATCH net-next] myri10ge: add adaptive coalescing

[Brice Goglin <bgoglin@free.fr>]

Rick Jones wrote:
> David Miller wrote:
>> From: Brice Goglin <brice@myri.com>
>> Date: Tue, 06 Oct 2009 18:52:43 +0200
>>
>>
>>> This patch adds support for adaptive interrupt coalescing to the
>>> myri10ge driver. It is based on the host periodically look at
>>> statistics and update the NIC coalescing accordingly.
>>>
>>> The NIC only provides packet throughput and we feel that it is a
>>> better heuristics than the packet rate heuristics currently used
>>> in ethtool. Also, assuming that the packet packet rate heuristics
>>> uses what is actually sent on the wire when using TSO, it would be
>>> much more expensive to implement correctly, as the driver would
>>> need to calculate how many packets were sent.
>>>
>>> Signed-off-by: Andrew Gallatin <gallatin@myri.com>
>>> Signed-off-by: Brice Goglin <brice@myri.com>
>>
>>
>> Drivers tried to do this as far back as 6 years ago (tg3) and we don't
>> recommend doing this with NAPI drivers.
>
> Doesn't e1000(e) still try to do adaptive coalescing?

mlx_en, benet, sfc, ... do as well.

Brice