From: Simon Farnsworth <simon.farnsworth@onelan.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org
Subject: Re: r8169 chips on some Intel D945GSEJT boards fail to work after PXE boot
Date: Wed, 07 Oct 2009 11:39:52 +0100 [thread overview]
Message-ID: <4ACC6FF8.1030504@onelan.com> (raw)
In-Reply-To: <20091006215601.GA10692@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Francois Romieu <romieu@fr.zoreil.com> :
> [...]
>> @@ -2200,6 +3075,11 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>> tp->pcie_cap = pci_find_capability(pdev, PCI_CAP_ID_EXP);
>> if (!tp->pcie_cap && netif_msg_probe(tp))
>> dev_info(&pdev->dev, "no PCI Express capability\n");
>> + else {
>> + pci_write_config_word(pdev, tp->pcie_cap + PCI_EXP_DEVSTA,
>> + PCI_EXP_DEVSTA_CED | PCI_EXP_DEVSTA_NFED |
>> + PCI_EXP_DEVSTA_FED | PCI_EXP_DEVSTA_URD);
>> + }
>>
>> RTL_W16(IntrMask, 0x0000);
>>
>
> Can you check if this part of the patch is required to fix
> your issue ?
>
> I'd rather avoid including it under the 8168d support banner
> if it is not needed.
>
I can confirm that I don't need that hunk.
--
Simon Farnsworth
prev parent reply other threads:[~2009-10-07 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 16:57 r8169 chips on some Intel D945GSEJT boards fail to work after PXE boot Simon Farnsworth
2009-09-23 20:57 ` Francois Romieu
2009-09-24 11:12 ` Simon Farnsworth
2009-09-30 22:07 ` Francois Romieu
2009-10-05 9:47 ` Simon Farnsworth
2009-10-06 21:56 ` Francois Romieu
2009-10-07 10:39 ` Simon Farnsworth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACC6FF8.1030504@onelan.com \
--to=simon.farnsworth@onelan.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.