Re: [Qemu-devel] [RFC PATCH v2 3/5] ne2k: work without vlan.

[Anthony Liguori <anthony@codemonkey.ws>]

Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/ne2000.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ne2000.c b/hw/ne2000.c
> index 87f1e59..0ed6eec 100644
> --- a/hw/ne2000.c
> +++ b/hw/ne2000.c
> @@ -322,7 +322,8 @@ void ne2000_ioport_write(void *opaque, uint32_t addr, uint32_t val)
>                      index -= NE2000_PMEM_SIZE;
>                  /* fail safe: check range on the transmitted length  */
>                  if (index + s->tcnt <= NE2000_PMEM_END) {
> -                    qemu_send_packet(s->vc, s->mem + index, s->tcnt);
> +                    if (s->vc)
> +                        qemu_send_packet(s->vc, s->mem + index, s->tcnt);
>                  }
>   

Perhaps we should just push the s->vc check into qemu_send_packet since 
we want this behavior consistently.

Regards,

Anthony Liguori