From: Anthony Liguori <anthony@codemonkey.ws>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread"
Date: Wed, 07 Oct 2009 11:28:21 -0500 [thread overview]
Message-ID: <4ACCC1A5.5020306@codemonkey.ws> (raw)
In-Reply-To: <Pine.LNX.4.64.0910072000090.2178@linmac.oyster.ru>
> There's nothing to review in this particular case, the thing was plain
> broken, besides same thing was already discussed between me and
> Andrzej, see for instance:
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg09542.html
>
> Needless to say the revert is broken also.
>
Yeah, I understand the race the original commit fixes but I don't
understand how the original commit broke WinXP.
Do you have further insight Michael? Blindly reverting something that
appears right because of a regression is likely just papering over a
bigger problem.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-10-07 16:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 13:20 [Qemu-devel] [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread" Michael S. Tsirkin
2009-10-07 16:04 ` [Qemu-devel] " malc
2009-10-07 16:28 ` Anthony Liguori [this message]
2009-10-07 16:33 ` Michael S. Tsirkin
2009-10-07 20:44 ` Michael S. Tsirkin
2009-10-07 20:54 ` malc
2009-10-07 20:55 ` Michael S. Tsirkin
2009-10-07 21:01 ` malc
2009-10-08 1:47 ` Jamie Lokier
2009-10-08 2:48 ` malc
2009-10-08 15:15 ` Jamie Lokier
2009-10-08 16:39 ` malc
2009-10-09 11:12 ` Jamie Lokier
2009-10-09 13:13 ` malc
2009-10-08 21:24 ` Michael S. Tsirkin
2009-10-08 21:50 ` Anthony Liguori
2009-10-08 21:51 ` Anthony Liguori
2009-10-09 11:13 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACCC1A5.5020306@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=av1474@comtv.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.