All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentin Manea <atheros@mrs.ro>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] Disabling Link-Layer Acks
Date: Wed, 07 Oct 2009 20:16:53 +0300	[thread overview]
Message-ID: <4ACCCD05.2030904@mrs.ro> (raw)
In-Reply-To: <alpine.LFD.2.00.0910072240460.32164@ranga-desktop>

Thanks for your answer.
I did some tests and setting the diag bit also disables BlockAck being 
sent in HT mode.

Best Regards,
Valentin

On 10/07/2009 08:11 PM, Ranga Rao Ravuri wrote:
> You cannot disable ACK-rx, as mentioned here, setting DIAG bit should help
> *not* sending ACK
> ~ R
>
>
> On Wed, 7 Oct 2009, Valentin Manea wrote:
>
>    
>>
>> On 10/07/2009 09:12 AM, Sujith wrote:
>>      
>>> Matt Tierney wrote:
>>>
>>>        
>>>> This is bumping an old question<http://www.mail-archive.com/ath9k-devel@lists.ath9k.org/msg00016.html>   but I was wondering if there was a simple (quick and dirty, if need be) way to disable link-layer acks.
>>>>
>>>> I think I found the right place to do this in the xmit.c code, under the setup_tx_flags function:
>>>>
>>>>           if (tx_info->flags&   IEEE80211_TX_CTL_NO_ACK)
>>>>                   flags |= ATH9K_TXDESC_NOACK;
>>>>
>>>> I expect that I would just need to comment out the first line with the if-condition.
>>>>
>>>> Is this a correct way to handle disabling link-layer acks for now?
>>>>
>>>>          
>>> No. That flag is used to indicate whether we should
>>> expect an ACK for the frame being sent.
>>>
>>> The correct way would be to set AR_DIAG_ACK_DIS in AR_DIAG_SW (reg.h)
>>>
>>>        
>> Hi Sujit,
>>
>>     As I'm interested in this, I was wondering if setting this bit also
>> disables sending the BlockAcks?
>>
>>
>> Thanks
>> _______________________________________________
>> ath9k-devel mailing list
>> ath9k-devel at lists.ath9k.org
>> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
>>
>>      

  reply	other threads:[~2009-10-07 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 16:50 [ath9k-devel] Disabling Link-Layer Acks Matt Tierney
2009-10-02 21:29 ` Luis R. Rodriguez
2009-10-07  6:12 ` Sujith
2009-10-07 16:14   ` Valentin Manea
2009-10-07 17:11     ` Ranga Rao Ravuri
2009-10-07 17:16       ` Valentin Manea [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-07-29 14:16 [ath9k-devel] Disabling link-layer ACKs William Usher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACCCD05.2030904@mrs.ro \
    --to=atheros@mrs.ro \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.