All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: rostedt@goodmis.org
Cc: Zhenwen Xu <helight.xu@gmail.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH V4] fix warning on kernel/trace/trace_branch.c andtrace_hw_branches.c
Date: Thu, 08 Oct 2009 09:37:42 +0800	[thread overview]
Message-ID: <4ACD4266.2050902@cn.fujitsu.com> (raw)
In-Reply-To: <1254965540.1696.198.camel@gandalf.stny.rr.com>

>> diff --git a/kernel/trace/trace_hw_branches.c b/kernel/trace/trace_hw_branches.c
>> index 23b6385..52a5903 100644
>> --- a/kernel/trace/trace_hw_branches.c
>> +++ b/kernel/trace/trace_hw_branches.c
>> @@ -165,6 +165,7 @@ void trace_hw_branch(u64 from, u64 to)
>>  	struct ftrace_event_call *call = &event_hw_branch;
>>  	struct trace_array *tr = hw_branch_trace;
>>  	struct ring_buffer_event *event;
>> +	struct ring_buffer *buf;
>>  	struct hw_branch_entry *entry;
>>  	unsigned long irq1;
>>  	int cpu;
>> @@ -180,7 +181,8 @@ void trace_hw_branch(u64 from, u64 to)
>>  	if (atomic_inc_return(&tr->data[cpu]->disabled) != 1)
>>  		goto out;
>>  
>> -	event = trace_buffer_lock_reserve(tr, TRACE_HW_BRANCHES,
>> +	buf = tr->buffer

And here won't compile..

>> +	event = trace_buffer_lock_reserve(buf, TRACE_HW_BRANCHES,
>>  					  sizeof(*entry), 0, 0);

  reply	other threads:[~2009-10-08  1:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 11:39 [PATCH V3] fix a warning on kernel/trace/trace_branch.c andtrace_hw_branches.c Zhenwen Xu
2009-10-07 15:36 ` Frederic Weisbecker
2009-10-08  0:52 ` Li Zefan
2009-10-08  1:08   ` Steven Rostedt
2009-10-08  1:21 ` [PATCH V4] fix " Zhenwen Xu
2009-10-08  1:32   ` Steven Rostedt
2009-10-08  1:37     ` Li Zefan [this message]
2009-10-08  1:41       ` Steven Rostedt
2009-10-08 13:47   ` [tip:tracing/urgent] tracing: " tip-bot for Zhenwen Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACD4266.2050902@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=helight.xu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.